linux-kernel - Re: [PATCH V2] arm64: kconfig: allow support for memory failure handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170222114342.tz5wmnynwjos44fd@pd.tnic>
Date:   Wed, 22 Feb 2017 12:43:42 +0100
From:   Borislav Petkov <bp@...e.de>
To:     "Rafael J. Wysocki" <rjw@...ysocki.net>
Cc:     Tyler Baicar <tbaicar@...eaurora.org>, catalin.marinas@....com,
        will.deacon@....com, lenb@...nel.org,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        linux-acpi@...r.kernel.org, punit.agrawal@....com,
        "Jonathan (Zhixiong) Zhang" <zjzhang@...eaurora.org>
Subject: Re: [PATCH V2] arm64: kconfig: allow support for memory failure
 handling

On Wed, Feb 22, 2017 at 01:53:54AM +0100, Rafael J. Wysocki wrote:
> [+ Boris]
> 
> On Tuesday, February 21, 2017 04:45:23 PM Tyler Baicar wrote:
> > From: "Jonathan (Zhixiong) Zhang" <zjzhang@...eaurora.org>
> > 
> > If ACPI_APEI and MEMORY_FAILURE is configured, select
> > ACPI_APEI_MEMORY_FAILURE. This enables memory failure recovery
> > when such memory failure is reported through ACPI APEI. APEI
> > (ACPI Platform Error Interfaces) provides a means for the
> > platform to convey error information to the kernel.
> > 
> > Declare ARCH_SUPPORTS_MEMORY_FAILURE, as arm64 does support
> > memory failure recovery attempt.
> > 
> > Signed-off-by: Jonathan (Zhixiong) Zhang <zjzhang@...eaurora.org>
> > Signed-off-by: Tyler Baicar <tbaicar@...eaurora.org>
> > ---
> >  arch/arm64/Kconfig        | 1 +
> >  drivers/acpi/apei/Kconfig | 1 +
> >  2 files changed, 2 insertions(+)
> > 
> > diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig
> > index 1117421..61e0bb0 100644
> > --- a/arch/arm64/Kconfig
> > +++ b/arch/arm64/Kconfig
> > @@ -15,6 +15,7 @@ config ARM64
> >  	select ARCH_HAS_SG_CHAIN
> >  	select ARCH_HAS_TICK_BROADCAST if GENERIC_CLOCKEVENTS_BROADCAST
> >  	select ARCH_USE_CMPXCHG_LOCKREF
> > +	select ARCH_SUPPORTS_MEMORY_FAILURE
> >  	select ARCH_SUPPORTS_ATOMIC_RMW
> >  	select ARCH_SUPPORTS_NUMA_BALANCING
> >  	select ARCH_WANT_COMPAT_IPC_PARSE_VERSION
> > diff --git a/drivers/acpi/apei/Kconfig b/drivers/acpi/apei/Kconfig
> > index b0140c8..6d9a812 100644
> > --- a/drivers/acpi/apei/Kconfig
> > +++ b/drivers/acpi/apei/Kconfig
> > @@ -9,6 +9,7 @@ config ACPI_APEI
> >  	select MISC_FILESYSTEMS
> >  	select PSTORE
> >  	select UEFI_CPER
> > +	select ACPI_APEI_MEMORY_FAILURE if MEMORY_FAILURE

Yap, looks ok to me: we're basically enabling
ghes_handle_memory_failure() to queue a memory address at fault for
possibly offlining on arm64. And since the arch supports it...

-- 
Regards/Gruss,
    Boris.

SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg)
--