linux-kernel - Re: [PATCH 1/2] Correct function definition for C++

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170222130318.GB15769@kroah.com>
Date:   Wed, 22 Feb 2017 14:03:18 +0100
From:   "greg@...ah.com" <greg@...ah.com>
To:     Joakim Tjernlund <Joakim.Tjernlund@...inera.com>
Cc:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "stable@...r.kernel.org" <stable@...r.kernel.org>
Subject: Re: [PATCH 1/2] Correct function definition for C++

On Wed, Feb 22, 2017 at 07:50:46AM +0000, Joakim Tjernlund wrote:
> On Wed, 2017-02-22 at 08:10 +0100, Greg KH wrote:
> > On Tue, Feb 21, 2017 at 04:24:04PM +0100, Joakim Tjernlund wrote:
> > > C++ does does not like the extra extern before asmlinkage, remove it.
> > > 
> > > Signed-off-by: Joakim Tjernlund <joakim.tjernlund@...inera.com>
> > > ---
> > >  include/linux/printk.h | 4 ++--
> > >  1 file changed, 2 insertions(+), 2 deletions(-)
> > > 
> > > diff --git a/include/linux/printk.h b/include/linux/printk.h
> > > index 3472cc6..be823f5 100644
> > > --- a/include/linux/printk.h
> > > +++ b/include/linux/printk.h
> > 
> > 
> > Why are you building this file with a C++ compiler?
> 
> virtualbox uses C++ and includes various kernel headers and the build
> fails, virtualbox guest additions has not build for quite some time now and
> this is one of the problems.

Virtualbox is a horrid pile of crap.  You can quote me on that.  We
don't care about out-of-tree drivers, the authors should work to get
them merged properly if they do care.

Kernel code should be C, not C++, and if you do want to use C++, then
you are on your own, sorry.

> > Also, this is not the correct way to submit patches for inclusion in the
> > stable kernel tree.  Please read Documentation/stable_kernel_rules.txt
> > for how to do this properly.
> 
> Sorry, I was in a hurry(lazy:) so I just included stable directly as
> I know it needs to be fixed in 4.9 as well.

But that's not how to get a patch into the stable tree :(

sorry,

greg k-h