linux-kernel - Re: [GIT PULL] cputime: Convert core use of cputime

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 22 Feb 2017 15:30:16 +0100
From:   Frederic Weisbecker <fweisbec@...il.com>
To:     hejianet <hejianet@...il.com>
Cc:     Ingo Molnar <mingo@...nel.org>,
        LKML <linux-kernel@...r.kernel.org>,
        Tony Luck <tony.luck@...el.com>,
        Wanpeng Li <wanpeng.li@...mail.com>,
        Peter Zijlstra <peterz@...radead.org>,
        Michael Ellerman <mpe@...erman.id.au>,
        Heiko Carstens <heiko.carstens@...ibm.com>,
        Benjamin Herrenschmidt <benh@...nel.crashing.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Paul Mackerras <paulus@...ba.org>,
        Fenghua Yu <fenghua.yu@...el.com>,
        Rik van Riel <riel@...hat.com>,
        Martin Schwidefsky <schwidefsky@...ibm.com>,
        Stanislaw Gruszka <sgruszka@...hat.com>
Subject: Re: [GIT PULL] cputime: Convert core use of cputime_t to nsecs

On Tue, Feb 21, 2017 at 01:08:24PM +0800, hejianet wrote:
> Hi Frederic
> 
> Do we need to support CONFIG_VIRT_CPU_ACCOUNTING_NATIVE=n on ppc64le?
> 
> If yes, I got a compiling error after applying your patch set:
> 
> arch/powerpc/kernel/time.c:712:2: error: implicit declaration of function
> ‚Äòcputime_to_nsecs‚Äô [-Werror=implicit-function-declaration]
>   return local_clock() -
> cputime_to_nsecs(kcpustat_this_cpu->cpustat[CPUTIME_STEAL]);
>   ^
> 
> I thought it is due to CONFIG_VIRT_CPU_ACCOUNTING_NATIVE=n on my ppc64le server.
> My kernel config:
> # grep -n CONFIG_VIRT_CPU .config
> 136:CONFIG_VIRT_CPU_ACCOUNTING=y
> 137:CONFIG_VIRT_CPU_ACCOUNTING_GEN=y

Thanks for reporting! I posted a fix yesterday:

       "powerpc: Remove leftover cputime_to_nsecs call causing build error"
       https://lkml.org/lkml/2017/2/21/393