lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Wed, 22 Feb 2017 15:37:37 +0100
From:   Linus Walleij <>
To:     Charles Keepax <>
Cc:     Krzysztof Kozlowski <>,
        Tomasz Figa <>,
        Sylwester Nawrocki <>,
        "" <>,
        linux-samsung-soc <>,
        "" <>,
Subject: Re: [PATCH v2 2/4] pinctrl: samsung: Register pinctrl before GPIO

On Thu, Feb 16, 2017 at 2:27 PM, Charles Keepax
<> wrote:

> If we request a GPIO hog, then gpiochip_add_data will attempt to request
> some of its own GPIOs. The driver also uses gpiochip_generic_request
> which means that for any GPIO request to succeed the pinctrl needs to be
> registered. Currently however the driver registers the GPIO and then the
> pinctrl meaning all GPIO hog requests will fail, which then in turn causes
> the whole driver to fail probe. Fix this up by ensuring we register the
> pinctrl first. Although currently there are no users of GPIO hogs in
> mainline there are plenty of Samsung based boards that are widely used
> for development purposes of other hardware. Indeed we hit this issue
> whilst attaching some additional hardware to an Arndale system.
> Signed-off-by: Charles Keepax <>
> Reviewed-by: Krzysztof Kozlowski <>
> ---
> Changes since v1:
>  - Updated commit message

Patch applied. Will not be visible in -next until after the merge window

Linus Walleij

Powered by blists - more mailing lists