linux-kernel - Re: [PATCH v2 1/2] usbip: Fix-format-overflow

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1487787265.13719.10.camel@lesbg.com>
Date:   Wed, 22 Feb 2017 20:14:25 +0200
From:   Jonathan Dieter <jdieter@...bg.com>
To:     Krzysztof Opasiak <k.opasiak@...sung.com>,
        linux-kernel@...r.kernel.org
Cc:     Valentina Manea <valentina.manea.m@...il.com>,
        Shuah Khan <shuah@...nel.org>,
        Peter Senna Tschudin <peter.senna@...il.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        "open list:USB OVER IP DRIVER" <linux-usb@...r.kernel.org>
Subject: Re: [PATCH v2 1/2] usbip: Fix-format-overflow

On Wed, 2017-02-22 at 06:49 +0100, Krzysztof Opasiak wrote:
> Hi,
> 
> W dniu 2017-02-21 o 18:57, Jonathan Dieter pisze:
<snip>
> >  	char busid[SYSFS_BUS_ID_SIZE];
> > +	unsigned int size;
> 
> I'm not really convinced to use unsigned here. snprintf() is declared
> to 
> return signed integer so we should assume that some of its 
> implementation may return negative error code. Any rationale to this 
> instead of just doing a cast for comparsion but signed value to print
> error?

No, you're absolutely right.  I've fixed this and am sending the next
revision now.

Jonathan