linux-kernel - Re: [PATCH] score: Add missing include files

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170222195854.GB3041@roeck-us.net>
Date:   Wed, 22 Feb 2017 11:58:54 -0800
From:   Guenter Roeck <linux@...ck-us.net>
To:     Paul Gortmaker <paul.gortmaker@...driver.com>
Cc:     Chen Liqin <liqin.linux@...il.com>,
        Lennox Wu <lennox.wu@...il.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] score: Add missing include files

On Wed, Feb 22, 2017 at 02:46:33PM -0500, Paul Gortmaker wrote:
> [[PATCH] score: Add missing include files] On 22/02/2017 (Wed 11:07) Guenter Roeck wrote:
> 
> > Kernel builds fail with
> > 
> > arch/score/kernel/traps.c: In function 'do_ri':
> > arch/score/kernel/traps.c:248:4: error:
> > 	implicit declaration of function 'user_disable_single_step'
> > arch/score/mm/extable.c: In function 'fixup_exception':
> > arch/score/mm/extable.c:32:38: error:
> > 	dereferencing pointer to incomplete type
> > arch/score/mm/extable.c:34:24: error:
> > 	dereferencing pointer to incomplete type
> > 
> > Fixes: 0f296af85be8 ("score: migrate exception table users off ...")
> 
> Not surprising, neither me/korg[1] nor kbuild nor linux-next have score
> tc for build coverage, so score got the "this looks right" treatment.
> 
> Too bad your coverage didn't use linux-next over the last couple weeks,
> as then it could have been in the pull request I'd just sent.  Oh well.
> 
It did, and it reported it, but reports are manual and unfortunately
I don't always have time for an immediate bisect.

> Mind if I ask where you got your toolchain?  I'm not in a position to
> futz around trying to build one myself for some of these less common
> architectures, but I'm not against extending my coverage using existing
> toolchains.
> 
I use http://server.roeck-us.net/toolchains/score.tgz, which I picked up
from the internet some time ago (don't ask me where).

Guenter