linux-kernel - Re: [PATCH] uapi: fix linux/if.h userspace compilation errors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20170222.160928.487250706697602435.davem@davemloft.net>
Date:   Wed, 22 Feb 2017 16:09:28 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     ldv@...linux.org
Cc:     netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] uapi: fix linux/if.h userspace compilation errors

From: "Dmitry V. Levin" <ldv@...linux.org>
Date: Tue, 21 Feb 2017 23:19:14 +0300

> On Tue, Feb 21, 2017 at 12:10:22PM -0500, David Miller wrote:
>> From: "Dmitry V. Levin" <ldv@...linux.org>
>> Date: Mon, 20 Feb 2017 14:58:41 +0300
>> 
>> > Include <sys/socket.h> (guarded by ifndef __KERNEL__) to fix
>> > the following linux/if.h userspace compilation errors:
>> 
>> Wouldn't it be so much better to do this in include/uapi/linux/socket.h?
> 
> Yes, it would be nicer if we could afford it.  However, changing
> uapi/linux/socket.h to include <sys/socket.h> is less conservative than
> changing every uapi header that fails to compile because of its use
> of struct sockaddr.  It's risky because <sys/socket.h> pulls in other
> types that might conflict with definitions provided by uapi headers.

Ok, I'll apply this for now.