linux-kernel - Re: [PATCH 2/3] mfd: cros_ec: add debugfs, console log file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAD=FV=Unuhxbiw6sEiMsgKBxkmCUiJ6m2M9LOQ4W90gpRXPLwA@mail.gmail.com>
Date:   Wed, 22 Feb 2017 13:49:06 -0800
From:   Doug Anderson <dianders@...omium.org>
To:     Nicolas Boichat <drinkcat@...omium.org>
Cc:     Lee Jones <lee.jones@...aro.org>,
        "gwendal@...omium.org" <gwendal@...omium.org>,
        ejcaruso@...omium.org, Olof Johansson <olof@...om.net>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Guenter Roeck <groeck@...omium.org>,
        Enric Balletbo i Serra <enric.balletbo@...labora.com>,
        Thierry Escande <thierry.escande@...labora.com>,
        Benson Leung <bleung@...omium.org>
Subject: Re: [PATCH 2/3] mfd: cros_ec: add debugfs, console log file

Hi,

I'm not sure what happened to this patch, but I found it when making
sure that the bugfix pointed out in
<https://chromium-review.googlesource.com/c/444085/3/drivers/platform/chrome/cros_ec_debugfs.c#240>.
Presumably someone will want to pick it up eventually?  +Benson

On Mon, Aug 22, 2016 at 9:34 PM, Nicolas Boichat <drinkcat@...omium.org> wrote:
> +static int ec_read_version_supported(struct cros_ec_dev *ec)
> +{
> +       struct ec_params_get_cmd_versions_v1 *params;
> +       struct ec_response_get_cmd_versions *response;
> +       int ret;
> +
> +       struct cros_ec_command *msg;
> +
> +       msg = kzalloc(sizeof(*msg) + max(sizeof(params), sizeof(response)),
> +               GFP_KERNEL);
> +       if (!msg)
> +               return 0;
> +
> +       msg->command = EC_CMD_GET_CMD_VERSIONS + ec->cmd_offset;
> +       msg->outsize = sizeof(params);
> +       msg->insize = sizeof(response);

The above sizeof() calls are wrong.  They need "*"