linux-kernel - [PATCH v3] ncpfs: Remove cast from memory allocation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [day] [month] [year] [list]

Date:   Thu, 23 Feb 2017 09:02:50 +1100
From:   "Tobin C. Harding" <me@...in.cc>
To:     Petr Vandrovec <petr@...drovec.name>
Cc:     "Tobin C. Harding" <me@...in.cc>, Jan Kara <jack@...e.cz>,
        Miklos Szeredi <mszeredi@...hat.com>,
        kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: [PATCH v3] ncpfs: Remove cast from memory allocation

Coccinelle emits WARNING: casting value returned by memory allocation
function to (struct ncp_inode_info *) is useless.

Remove unnecessary cast.

Signed-off-by: Tobin C. Harding <me@...in.cc>
---

Changes since v2:
 - Put version amendment comments in correct place within patch email.

Changes since v1:
 - Fix up typo

Kernel built successfully with patch applied.

 fs/ncpfs/inode.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/ncpfs/inode.c b/fs/ncpfs/inode.c
index 7eb89c2..7a9ed33 100644
--- a/fs/ncpfs/inode.c
+++ b/fs/ncpfs/inode.c
@@ -52,7 +52,7 @@ static struct kmem_cache * ncp_inode_cachep;
 static struct inode *ncp_alloc_inode(struct super_block *sb)
 {
 	struct ncp_inode_info *ei;
-	ei = (struct ncp_inode_info *)kmem_cache_alloc(ncp_inode_cachep, GFP_KERNEL);
+	ei = kmem_cache_alloc(ncp_inode_cachep, GFP_KERNEL);
 	if (!ei)
 		return NULL;
 	return &ei->vfs_inode;
-- 
2.7.4