linux-kernel - Re: [RESEND PATCH] dmaengine: bcm2835: Fix cyclic DMA period splitting

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170222024140.GV2843@localhost>
Date:   Wed, 22 Feb 2017 08:11:41 +0530
From:   Vinod Koul <vinod.koul@...el.com>
To:     Matthias Reichl <hias@...us.com>,
        Stephen Warren <swarren@...dotorg.org>,
        Lee Jones <lee@...nel.org>, Eric Anholt <eric@...olt.net>,
        Martin Sperl <kernel@...tin.sperl.org>,
        Clive Messer <clive.messer@...italdreamtime.co.uk>,
        dmaengine@...r.kernel.org, linux-rpi-kernel@...ts.infradead.org,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [RESEND PATCH] dmaengine: bcm2835: Fix cyclic DMA period
 splitting

On Mon, Feb 20, 2017 at 08:01:16PM +0100, Matthias Reichl wrote:
> The code responsible for splitting periods into chunks that
> can be handled by the DMA controller missed to update total_len,
> the number of bytes processed in the current period, when there
> are more chunks to follow.
> 
> Therefore total_len was stuck at 0 and the code didn't work at all.
> This resulted in a wrong control block layout and audio issues because
> the cyclic DMA callback wasn't executing on period boundaries.
> 
> Fix this by adding the missing total_len update.

Applied, thanks

-- 
~Vinod