linux-kernel - Re: [PATCH 2/4] input:touchscreen:ad7879-spi.c: Remove bits_per

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170223084118.GH18639@dtor-ws>
Date:   Thu, 23 Feb 2017 00:41:18 -0800
From:   Dmitry Torokhov <dmitry.torokhov@...il.com>
To:     michael.hennerich@...log.com
Cc:     linux-input@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/4] input:touchscreen:ad7879-spi.c: Remove bits_per_word
 = 16 enforcement

On Wed, Feb 22, 2017 at 05:14:36PM +0100, michael.hennerich@...log.com wrote:
> From: Michael Hennerich <michael.hennerich@...log.com>
> 
> Using regmap this is no longer required.
> 
> Signed-off-by: Michael Hennerich <michael.hennerich@...log.com>

This gave me warnings about unused "err" variable, I removed it and
applied, thank you.

> ---
>  drivers/input/touchscreen/ad7879-spi.c | 7 -------
>  1 file changed, 7 deletions(-)
> 
> diff --git a/drivers/input/touchscreen/ad7879-spi.c b/drivers/input/touchscreen/ad7879-spi.c
> index b995891..904a2c2 100644
> --- a/drivers/input/touchscreen/ad7879-spi.c
> +++ b/drivers/input/touchscreen/ad7879-spi.c
> @@ -42,13 +42,6 @@ static int ad7879_spi_probe(struct spi_device *spi)
>  		return -EINVAL;
>  	}
>  
> -	spi->bits_per_word = 16;
> -	err = spi_setup(spi);
> -	if (err) {
> -		dev_dbg(&spi->dev, "spi master doesn't support 16 bits/word\n");
> -		return err;
> -	}
> -
>  	regmap = devm_regmap_init_spi(spi, &ad7879_spi_regmap_config);
>  	if (IS_ERR(regmap))
>  		return PTR_ERR(regmap);
> -- 
> 2.7.4
> 

-- 
Dmitry