lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:   Thu, 23 Feb 2017 00:43:48 -0800
From:   Dmitry Torokhov <dmitry.torokhov@...il.com>
To:     michael.hennerich@...log.com
Cc:     linux-input@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/4] input:touchscreen:ad7879-spi.c: Fix regmap flag_masks

On Wed, Feb 22, 2017 at 05:14:35PM +0100, michael.hennerich@...log.com wrote:
> From: Michael Hennerich <michael.hennerich@...log.com>
> 
> Mask only applied to the top byte of the register
> 
> Signed-off-by: Michael Hennerich <michael.hennerich@...log.com>

Thank you Michael, I folded it with the patch introducing regmaps.

> ---
>  drivers/input/touchscreen/ad7879-spi.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/input/touchscreen/ad7879-spi.c b/drivers/input/touchscreen/ad7879-spi.c
> index f2c06b5..b995891 100644
> --- a/drivers/input/touchscreen/ad7879-spi.c
> +++ b/drivers/input/touchscreen/ad7879-spi.c
> @@ -19,8 +19,8 @@
>  
>  #define MAX_SPI_FREQ_HZ      5000000
>  
> -#define AD7879_CMD_MAGIC     0xE000
> -#define AD7879_CMD_READ      BIT(10)
> +#define AD7879_CMD_MAGIC     0xE0
> +#define AD7879_CMD_READ      BIT(2)
>  
>  static const struct regmap_config ad7879_spi_regmap_config = {
>  	.reg_bits = 16,
> -- 
> 2.7.4
> 

-- 
Dmitry

Powered by blists - more mailing lists