linux-kernel - Re: [PATCH] staging: speakup: synth: Fix checkpatch warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1487856855.14159.26.camel@perches.com>
Date:   Thu, 23 Feb 2017 05:34:15 -0800
From:   Joe Perches <joe@...ches.com>
To:     Man Choy <manchoyy@...il.com>
Cc:     William Hubbs <w.d.hubbs@...il.com>,
        Chris Brannon <chris@...-brannons.com>,
        Kirk Reiser <kirk@...sers.ca>,
        Samuel Thibault <samuel.thibault@...-lyon.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Walt Feasel <waltfeasel@...il.com>,
        Amitoj Kaur Chawla <amitoj1606@...il.com>,
        Colin Ian King <colin.king@...onical.com>,
        Katie Dunne <kdunne@...l.ccsf.edu>, speakup@...ux-speakup.org,
        devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: speakup: synth: Fix checkpatch warning

On Thu, 2017-02-23 at 21:15 +0800, Man Choy wrote:
[]
> diff --git a/drivers/staging/speakup/synth.c b/drivers/staging/speakup/synth.c
[]
> @@ -407,7 +407,7 @@ static int do_synth_init(struct spk_synth *in_synth)
>  	if (!spk_quiet_boot)
>  		synth_printf("%s found\n", synth->long_name);
>  	if (synth->attributes.name && sysfs_create_group(speakup_kobj,
> -							 &synth->attributes) < 0)
> +		&synth->attributes) < 0)

Better would be

	if (synth->attributes.name &&
	    sysfs_create_group(speakup_kobj, &synth->attributes) < 0)