linux-kernel - Re: [PATCH 05/11] drm/sun4i: Initialize crtc from tcon bind function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170223182451.vpzuf3pey3jly4te@lukather>
Date:   Thu, 23 Feb 2017 10:24:51 -0800
From:   Maxime Ripard <maxime.ripard@...e-electrons.com>
To:     Chen-Yu Tsai <wens@...e.org>
Cc:     David Airlie <airlied@...ux.ie>, dri-devel@...ts.freedesktop.org,
        linux-sunxi@...glegroups.com, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 05/11] drm/sun4i: Initialize crtc from tcon bind function

On Thu, Feb 23, 2017 at 04:05:37PM +0800, Chen-Yu Tsai wrote:
> The tcon provides part of the functionality of the crtc, and also
> provides the device node for the output port of the crtc. To be able
> to use drm_of_find_possible_crtcs(), all crtc must be initialized before
> any downstream encoders. The other part of the crtc is the display
> backend.
> 
> The Rockchip DRM driver does this by first binding all vops, which is
> their crtc, and this step also creates the crtc objects. Then all
> remaining hardware components are bound. With the Allwinner display
> pipeline, we have multiple components comprising the crtc, and varying
> depths of the display pipeline. Since components are added with a depth
> first search of the of_graph, we can initialize the crtc object within
> the tcon bind function. Since the backend precedes the tcon, and the
> backends cannot be muxed or switched around, we can be sure that the
> associated backend is already initialized.
> 
> This patch also moves the crtc pointer from the main drm_device data to
> the tcon device data. Besides the crtc callbacks, the crtc structure is
> only used within the tcon driver to signal vblank events from its
> interrupt handler.
> 
> As the crtc and layer bits are now called from the tcon bits, we must
> move them from the sun4i-drm module to the sun4i-tcon module to avoid
> circular dependencies between the two modules. This is because sun4i-drm
> also calls into sun4i-tcon.
> 
> Signed-off-by: Chen-Yu Tsai <wens@...e.org>

Applied, thanks!
Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

Download attachment "signature.asc" of type "application/pgp-signature" (802 bytes)