linux-kernel - Re: [PATCH v4 03/17] x86/mpx, x86/insn: Relocate insn util functions to a new insn-kernel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 23 Feb 2017 14:18:04 -0800
From:   Ricardo Neri <ricardo.neri-calderon@...ux.intel.com>
To:     kbuild test robot <lkp@...el.com>
Cc:     kbuild-all@...org, Ingo Molnar <mingo@...hat.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        "H. Peter Anvin" <hpa@...or.com>,
        Andy Lutomirski <luto@...nel.org>,
        Borislav Petkov <bp@...e.de>,
        Peter Zijlstra <peterz@...radead.org>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Brian Gerst <brgerst@...il.com>,
        Chris Metcalf <cmetcalf@...lanox.com>,
        Dave Hansen <dave.hansen@...ux.intel.com>,
        Paolo Bonzini <pbonzini@...hat.com>,
        Liang Z Li <liang.z.li@...el.com>,
        Masami Hiramatsu <mhiramat@...nel.org>,
        Huang Rui <ray.huang@....com>, Jiri Slaby <jslaby@...e.cz>,
        Jonathan Corbet <corbet@....net>,
        "Michael S. Tsirkin" <mst@...hat.com>,
        Paul Gortmaker <paul.gortmaker@...driver.com>,
        Vlastimil Babka <vbabka@...e.cz>,
        Chen Yucong <slaoub@...il.com>,
        Alexandre Julliard <julliard@...ehq.org>,
        Stas Sergeev <stsp@...t.ru>, Fenghua Yu <fenghua.yu@...el.com>,
        "Ravi V. Shankar" <ravi.v.shankar@...el.com>,
        Shuah Khan <shuah@...nel.org>, linux-kernel@...r.kernel.org,
        x86@...nel.org, linux-msdos@...r.kernel.org, wine-devel@...ehq.org,
        Adam Buchbinder <adam.buchbinder@...il.com>,
        Colin Ian King <colin.king@...onical.com>,
        Lorenzo Stoakes <lstoakes@...il.com>,
        Qiaowei Ren <qiaowei.ren@...el.com>,
        Arnaldo Carvalho de Melo <acme@...hat.com>,
        Adrian Hunter <adrian.hunter@...el.com>,
        Kees Cook <keescook@...omium.org>,
        Thomas Garnier <thgarnie@...gle.com>,
        Dmitry Vyukov <dvyukov@...gle.com>
Subject: Re: [PATCH v4 03/17] x86/mpx, x86/insn: Relocate insn util
 functions to a new insn-kernel

On Thu, 2017-02-23 at 18:54 +0800, kbuild test robot wrote:
> >> arch/x86/lib/insn-eval.c:106:21: error: static declaration of
> 'insn_get_addr_ref' follows non-static declaration
>     static void __user *insn_get_addr_ref(struct insn *insn, struct
> pt_regs *regs)
>                         ^~~~~~~~~~~~~~~~~
>    In file included from arch/x86/lib/insn-eval.c:10:0:
>    arch/x86/include/asm/insn-eval.h:14:14: note: previous declaration
> of 'insn_get_addr_ref' was here
>     void __user *insn_get_addr_ref(struct insn *insn, struct pt_regs
> *regs);
>                  ^~~~~~~~~~~~~~~~~
>    arch/x86/lib/insn-eval.c:106:21: warning: 'insn_get_addr_ref'
> defined but not used [-Wunused-function]
>     static void __user *insn_get_addr_ref(struct insn *insn, struct
> pt_regs *regs)
>                         ^~~~~~~~~~~~~~~~~
> 
> vim +/insn_get_addr_ref +106 arch/x86/lib/insn-eval.c

Uh! This escaped my tests after many rebases. I will correct it.

Thanks and BR,
Ricardo