linux-kernel - Re: [GIT PULL] namespaces related fixes for v4.11-rc1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CALCETrU5SbbBq7ujuhVnBvm_8cX530zKNUycx0MiuhBqUgpwUQ@mail.gmail.com>
Date:   Wed, 22 Feb 2017 19:06:17 -0800
From:   Andy Lutomirski <luto@...capital.net>
To:     "Eric W. Biederman" <ebiederm@...ssion.com>
Cc:     Aleksa Sarai <asarai@...e.de>,
        Linus Torvalds <torvalds@...ux-foundation.org>,
        Linux FS Devel <linux-fsdevel@...r.kernel.org>,
        Linux API <linux-api@...r.kernel.org>,
        Linux Containers <containers@...ts.linux-foundation.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [GIT PULL] namespaces related fixes for v4.11-rc1

On Wed, Feb 22, 2017 at 5:29 PM, Eric W. Biederman
<ebiederm@...ssion.com> wrote:
> Aleksa Sarai <asarai@...e.de> writes:
>
>>> The only known user of this prctl systemd
>>> forks all children after the prctl.  So no userspace regressions will
>>> occur.
>>
>> Note that runC and containerd (and thus Docker) as well as cri-o use the prctl
>> as well -- to be able to collect exit codes from a non-child process (namely to
>> collect the exit code from PID 1 in the container).
>
> Are any of those affected by the change?  I would not expect so.  As it
> would require having children or grand children whose exit codes you
> don't want to collect.

FWIW, I have private code that uses PR_SET_CHILD_SUBREAPER, too.  I
don't see why it would be affected by this change.