linux-kernel - [PATCH] clk: zynqmp: fix itnull.cocci warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.20.1702240743040.2095@hadrien>
Date:   Fri, 24 Feb 2017 07:48:19 +0100 (CET)
From:   Julia Lawall <julia.lawall@...6.fr>
To:     Shubhrajyoti Datta <shubhrajyoti.datta@...inx.com>
cc:     Michal Simek <monstr@...str.eu>,
        Michael Turquette <mturquette@...libre.com>,
        Stephen Boyd <sboyd@...eaurora.org>,
        linux-arm-kernel@...ts.infradead.org, linux-clk@...r.kernel.org,
        linux-kernel@...r.kernel.org, kbuild-all@...org
Subject: [PATCH] clk: zynqmp: fix itnull.cocci warnings

Iterator variable bound on line 220 cannot be NULL

Generated by: scripts/coccinelle/iterators/itnull.cocci

CC: Shubhrajyoti Datta <shubhrajyoti.datta@...inx.com>
Signed-off-by: Julia Lawall <julia.lawall@...6.fr>
Signed-off-by: Fengguang Wu <fengguang.wu@...el.com>
---

tree:   https://github.com/Xilinx/linux-xlnx master
head:   1741e191412444e3ab3308b407a9328186c248e4
commit: 75b49bd76a45208749235a7ba35dba96e3e706f0 [358/384] clk: zynqmp:
Add check for no of users for vpll

Actually, the patch needs to be extended to drop the braces as well.

 clk.c |    2 --
 1 file changed, 2 deletions(-)

--- a/drivers/clk/clk.c
+++ b/drivers/clk/clk.c
@@ -218,8 +218,6 @@ static void clk_show_subtree(struct clk_
 		sibling++;

 	hlist_for_each_entry(child, &c->children, child_node) {
-		if (!child)
-			return;
 		clk_show_subtree(child, level + 1);
 	}
 }