linux-kernel - Re: [PATCH 3/3] f2fs: provide more chance for node and data to get ssr segment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3d4b064b-817f-402f-3eb5-df3ec7c06b44@huawei.com>
Date:   Fri, 24 Feb 2017 17:05:28 +0800
From:   Chao Yu <yuchao0@...wei.com>
To:     Jaegeuk Kim <jaegeuk@...nel.org>,
        Yunlong Song <yunlong.song@...wei.com>
CC:     <chao@...nel.org>, <sylinux@....com>, <miaoxie@...wei.com>,
        <bintian.wang@...wei.com>, <linux-fsdevel@...r.kernel.org>,
        <linux-f2fs-devel@...ts.sourceforge.net>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 3/3] f2fs: provide more chance for node and data to get
 ssr segment

Hi Jaegeuk,

Reviewed-by: Chao Yu <yuchao0@...wei.com>

For your attached two patches.

Thanks,

On 2017/2/23 9:17, Jaegeuk Kim wrote:
> Hi Yunlong,
> 
> I've been testing the similar patches as I attached.
> 
> Thanks,
> 
> On 02/22, Yunlong Song wrote:
>> Signed-off-by: Yunlong Song <yunlong.song@...wei.com>
>> ---
>>  fs/f2fs/segment.c | 9 +++++++++
>>  1 file changed, 9 insertions(+)
>>
>> diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c
>> index 9d13743..5fe71b9 100644
>> --- a/fs/f2fs/segment.c
>> +++ b/fs/f2fs/segment.c
>> @@ -1540,12 +1540,17 @@ static int get_ssr_segment(struct f2fs_sb_info *sbi, int type)
>>  {
>>  	struct curseg_info *curseg = CURSEG_I(sbi, type);
>>  	const struct victim_selection *v_ops = DIRTY_I(sbi)->v_ops;
>> +	int old_type = type;
>>  
>>  	if (IS_NODESEG(type)) {
>>  		for (; type >= CURSEG_HOT_NODE; type--)
>>  			if (v_ops->get_victim(sbi, &(curseg)->next_segno,
>>  							BG_GC, type, SSR))
>>  				return 1;
>> +		for (type = old_type + 1; type <= CURSEG_COLD_NODE; type++)
>> +			if (v_ops->get_victim(sbi, &(curseg)->next_segno,
>> +							BG_GC, type, SSR))
>> +				return 1;
>>  		return 0;
>>  	}
>>  
>> @@ -1554,6 +1559,10 @@ static int get_ssr_segment(struct f2fs_sb_info *sbi, int type)
>>  		if (v_ops->get_victim(sbi, &(curseg)->next_segno,
>>  						BG_GC, type, SSR))
>>  			return 1;
>> +	for (type = old_type + 1; type <= CURSEG_COLD_DATA; type++)
>> +		if (v_ops->get_victim(sbi, &(curseg)->next_segno,
>> +						BG_GC, type, SSR))
>> +			return 1;
>>  	return 0;
>>  }
>>  
>> -- 
>> 1.8.5.2