linux-kernel - Re: [PATCH v1 2/3] extcon: int3496: Rename GPIO pins in accordance with binding

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAHp75Vf-qJDX8fk1nRbzgUTGRaWK41fwO2y87Da-M+ob=3UjKQ@mail.gmail.com>
Date:   Fri, 24 Feb 2017 14:08:08 +0200
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Chanwoo Choi <cw00.choi@...sung.com>
Cc:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        MyungJoo Ham <myungjoo.ham@...sung.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Rob Herring <robh+dt@...nel.org>,
        devicetree <devicetree@...r.kernel.org>,
        David Cohen <david.a.cohen@...el.com>,
        Felipe Balbi <balbi@...nel.org>
Subject: Re: [PATCH v1 2/3] extcon: int3496: Rename GPIO pins in accordance
 with binding

On Fri, Feb 24, 2017 at 3:17 AM, Chanwoo Choi <cw00.choi@...sung.com> wrote:
> On 2017년 02월 23일 19:31, Andy Shevchenko wrote:
>> First of all, add an optional binding for external muxer which might be
>> used.

>> --- a/Documentation/devicetree/bindings/extcon/extcon-usb-gpio.txt
>> +++ b/Documentation/devicetree/bindings/extcon/extcon-usb-gpio.txt
>> @@ -10,6 +10,9 @@ Either one of id-gpio or vbus-gpio must be present. Both can be present as well.
>>  - id-gpio: gpio for USB ID pin. See gpio binding.
>>  - vbus-gpio: gpio for USB VBUS pin.
>>
>> +Optional properties:
>> +- mux-gpios: gpio for USB external muxer
>
> The Documentation/extcon/intel-int3496.txt includes
> already the information for id/vbus/mux pin.

Thanks for pointing this out...

> The extcon-usb-gpio.txt is not related with the extcon-int3496 driver.

...but the bindings is related to ACPI somehow. I dunno why in
extcon-usb-gpio.c we have
        if (!np && !ACPI_HANDLE(dev))

...and thus it means either firmware chooses we better to have
standardized bindings in both cases.

OTOH mux-gpios indeed doesn't make sense for extcon-usb-gpio.c and
would be removed from the bindings.

I'll update patches accordingly.

-- 
With Best Regards,
Andy Shevchenko