linux-kernel - Re: [PATCH] [v2] selftests, x86, pkeys: test with random, unallocated protection keys

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170224133133.GA3796@node.shutemov.name>
Date:   Fri, 24 Feb 2017 16:31:33 +0300
From:   "Kirill A. Shutemov" <kirill@...temov.name>
To:     Dave Hansen <dave.hansen@...ux.intel.com>
Cc:     linux-kernel@...r.kernel.org, x86@...nel.org,
        kirill.shutemov@...ux.intel.com, shuah@...nel.org,
        linux-kselftest@...r.kernel.org
Subject: Re: [PATCH] [v2] selftests, x86, pkeys: test with random,
 unallocated protection keys

On Thu, Feb 23, 2017 at 04:23:39PM -0800, Dave Hansen wrote:
> 
> 
> Changes from v1:
>  * Also generate random negative numbers for protection key
> 
> --
> From: Dave Hansen <dave.hansen@...ux.intel.com>
> 
> The kernel pkeys code had a minor bug where it did some large shifts
> to an integer which is undefined behavior in C.  It didn't cause any
> real harm, but it is screwy behavior that the kernel should have
> rejected.
> 
> Add a test case for this.
> 
> Signed-off-by: Dave Hansen <dave.hansen@...ux.intel.com>

Acked-by: Kirill A. Shutemov <kirill.shutemov@...ux.intel.com>

-- 
 Kirill A. Shutemov