linux-kernel - Re: [PATCH-SPEAKUP 1/2] return same error value from spk_set_key

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 24 Feb 2017 23:32:56 +0800
From:   kbuild test robot <lkp@...el.com>
To:     "Pranay Kr. Srivastava" <pranjas@...il.com>
Cc:     kbuild-all@...org, w.d.hubbs@...il.com, chris@...-brannons.com,
        kirk@...sers.ca, samuel.thibault@...-lyon.org,
        gregkh@...uxfoundation.org, sfr@...b.auug.org.au,
        speakup@...ux-speakup.org, devel@...verdev.osuosl.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH-SPEAKUP 1/2] return same error value from spk_set_key_info

Hi Pranay,

[auto build test WARNING on staging/staging-testing]
[also build test WARNING on v4.10]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Pranay-Kr-Srivastava/return-same-error-value-from-spk_set_key_info/20170222-152440
config: i386-randconfig-c0-02242210 (attached as .config)
compiler: gcc-4.9 (Debian 4.9.4-2) 4.9.4
reproduce:
        # save the attached .config to linux build tree
        make ARCH=i386 

All warnings (new ones prefixed by >>):

   In file included from include/linux/dynamic_debug.h:5:0,
                    from include/linux/printk.h:320,
                    from include/linux/kernel.h:13,
                    from drivers/staging/speakup/main.c:21:
   drivers/staging/speakup/main.c: In function 'spk_set_key_info':
>> include/linux/jump_label.h:377:59: warning: format '%lu' expects argument of type 'long unsigned int', but argument 4 has type 'unsigned int' [-Wformat=]
     else if (__builtin_types_compatible_p(typeof(*x), struct static_key_false)) \
                                                              ^
>> include/linux/dynamic_debug.h:102:2: note: in expansion of macro 'static_branch_unlikely'
     static_branch_unlikely(&descriptor.key.dd_key_false)
     ^
>> include/linux/dynamic_debug.h:125:6: note: in expansion of macro 'DYNAMIC_DEBUG_BRANCH'
     if (DYNAMIC_DEBUG_BRANCH(descriptor))   \
         ^
   include/linux/printk.h:324:2: note: in expansion of macro 'dynamic_pr_debug'
     dynamic_pr_debug(fmt, ##__VA_ARGS__)
     ^
   drivers/staging/speakup/main.c:1228:3: note: in expansion of macro 'pr_debug'
      pr_debug("too many key_infos (%d over %lu)\n",
      ^

vim +377 include/linux/jump_label.h

11276d53 Peter Zijlstra 2015-07-24  361  ({										\
11276d53 Peter Zijlstra 2015-07-24  362  	bool branch;								\
11276d53 Peter Zijlstra 2015-07-24  363  	if (__builtin_types_compatible_p(typeof(*x), struct static_key_true))	\
11276d53 Peter Zijlstra 2015-07-24  364  		branch = !arch_static_branch(&(x)->key, true);			\
11276d53 Peter Zijlstra 2015-07-24  365  	else if (__builtin_types_compatible_p(typeof(*x), struct static_key_false)) \
11276d53 Peter Zijlstra 2015-07-24  366  		branch = !arch_static_branch_jump(&(x)->key, true);		\
11276d53 Peter Zijlstra 2015-07-24  367  	else									\
11276d53 Peter Zijlstra 2015-07-24  368  		branch = ____wrong_branch_error();				\
11276d53 Peter Zijlstra 2015-07-24  369  	branch;									\
11276d53 Peter Zijlstra 2015-07-24  370  })
11276d53 Peter Zijlstra 2015-07-24  371  
11276d53 Peter Zijlstra 2015-07-24  372  #define static_branch_unlikely(x)						\
11276d53 Peter Zijlstra 2015-07-24  373  ({										\
11276d53 Peter Zijlstra 2015-07-24  374  	bool branch;								\
11276d53 Peter Zijlstra 2015-07-24  375  	if (__builtin_types_compatible_p(typeof(*x), struct static_key_true))	\
11276d53 Peter Zijlstra 2015-07-24  376  		branch = arch_static_branch_jump(&(x)->key, false);		\
11276d53 Peter Zijlstra 2015-07-24 @377  	else if (__builtin_types_compatible_p(typeof(*x), struct static_key_false)) \
11276d53 Peter Zijlstra 2015-07-24  378  		branch = arch_static_branch(&(x)->key, false);			\
11276d53 Peter Zijlstra 2015-07-24  379  	else									\
11276d53 Peter Zijlstra 2015-07-24  380  		branch = ____wrong_branch_error();				\
11276d53 Peter Zijlstra 2015-07-24  381  	branch;									\
11276d53 Peter Zijlstra 2015-07-24  382  })
11276d53 Peter Zijlstra 2015-07-24  383  
11276d53 Peter Zijlstra 2015-07-24  384  #else /* !HAVE_JUMP_LABEL */
11276d53 Peter Zijlstra 2015-07-24  385  

:::::: The code at line 377 was first introduced by commit
:::::: 11276d5306b8e5b438a36bbff855fe792d7eaa61 locking/static_keys: Add a new static_key interface

:::::: TO: Peter Zijlstra <peterz@...radead.org>
:::::: CC: Ingo Molnar <mingo@...nel.org>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (26365 bytes)