linux-kernel - Re: [PATCH] net: stmmac: unify registers dumps methods

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20170224.111340.2250960229537472520.davem@davemloft.net>
Date:   Fri, 24 Feb 2017 11:13:40 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     clabbe.montjoie@...il.com
Cc:     peppe.cavallaro@...com, alexandre.torgue@...com,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: stmmac: unify registers dumps methods

From: Corentin Labbe <clabbe.montjoie@...il.com>
Date: Thu, 23 Feb 2017 14:12:25 +0100

> The stmmac driver have two methods for registers dumps: via ethtool and
> at init (if NETIF_MSG_HW is enabled).
> 
> It is better to keep only one method, ethtool, since the other was ugly.
> 
> This patch convert all dump_regs() function from "printing regs" to
> "fill the reg_space used by ethtool".
> 
> Signed-off-by: Corentin Labbe <clabbe.montjoie@...il.com>
> Acked-by: Giuseppe Cavallaro <peppe.cavallaro@...com>

Applied.