linux-kernel - Re: [PATCH v3 2/6] staging: ks7010: fix coding style issue of enclosing complex macro value in parentheses

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170224170721.GA7142@kroah.com>
Date:   Fri, 24 Feb 2017 18:07:21 +0100
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Chetan Sethi <cpsethi369@...il.com>
Cc:     devel@...verdev.osuosl.org, punitvara@...il.com, wsa@...-dreams.de,
        mattkilgore12@...il.com, linux-kernel@...r.kernel.org,
        weiyongjun1@...wei.com, shiva@...ev.nl, bhumirks@...il.com
Subject: Re: [PATCH v3 2/6] staging: ks7010: fix coding style issue of
 enclosing complex macro value in parentheses

On Fri, Feb 17, 2017 at 06:47:39PM +0900, Chetan Sethi wrote:
> This is 02nd patch to file ks_wlan.h file fixing error of enclosing
> complex macro value in parentheses

No need to have the "This is the XXX patch..." in the changelog text,
you don't see that in any other commit logs, right?

> 
> Signed-off-by: Chetan Sethi <cpsethi369@...il.com>
> ---
> v2:
>  - split multiple changes across different patches
> v3:
>  - mentioned patch revision in subject
>  - incorporated review comment of correct indentation for do statement
> 
>  drivers/staging/ks7010/ks_wlan.h | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/ks7010/ks_wlan.h b/drivers/staging/ks7010/ks_wlan.h
> index 668202d..33d6b28 100644
> --- a/drivers/staging/ks7010/ks_wlan.h
> +++ b/drivers/staging/ks7010/ks_wlan.h
> @@ -36,8 +36,10 @@
>  
>  #ifdef KS_WLAN_DEBUG
>  #define DPRINTK(n, fmt, args...) \
> -                 if (KS_WLAN_DEBUG > (n)) \
> -			printk(KERN_NOTICE "%s: "fmt, __FUNCTION__, ## args)
> +        do { \

Always run checkpatch on your patches so you don't get a grumpy
maintainer telling you to run your patches through checkpatch!

Please fix up all 3 of these and resend.

thanks,

greg k-h