linux-kernel - Re: [PATCH] remove unnecessary initial allocation of vc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170224173740.GA2265@kroah.com>
Date:   Fri, 24 Feb 2017 18:37:40 +0100
From:   Greg KH <gregkh@...uxfoundation.org>
To:     "Pranay Kr. Srivastava" <pranjas@...il.com>
Cc:     w.d.hubbs@...il.com, chris@...-brannons.com, kirk@...sers.ca,
        samuel.thibault@...-lyon.org, sfr@...b.auug.org.au,
        speakup@...ux-speakup.org, devel@...verdev.osuosl.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] remove unnecessary initial allocation of vc

On Tue, Feb 21, 2017 at 07:33:32PM +0530, Pranay Kr. Srivastava wrote:
> This patch removes the unnecessary allocation of
> current foreground vc during initialization.
> 
> Also change the prototype of speakup_allocate to take
> extra argument of gfp_* flags. Thus not requiring
> GFP_ATOMIC during initialization.

That's two different things, please do this in two different patches.

And always say what driver/subsystem you are patching in your subject
line, like other patches for the same driver.

Please fix up and resend.

thanks,

greg k-h