lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:   Fri, 24 Feb 2017 18:41:50 +0100
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Joe Perches <joe@...ches.com>
Cc:     Yamanappagouda Patil <goudapatilk@...il.com>,
        devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org,
        driverdev-devel@...uxdriverproject.org
Subject: Re: [PATCH] staging: vc04_services: Fixed "space prohibited after
 that open/close parenthesis" erros.

On Thu, Feb 23, 2017 at 10:15:55AM -0800, Joe Perches wrote:
> On Thu, 2017-02-23 at 20:00 +0530, Yamanappagouda Patil wrote:
> > Fixed checkpath.pl erros "space prohibited after that open/close parenthesis" in vchiq_version.c file.
> > 
> > Signed-off-by: Yamanappagouda Patil <goudapatilk@...il.com>
> > ---
> >  .../vc04_services/interface/vchiq_arm/vchiq_version.c    | 16 ++++++++--------
> >  1 file changed, 8 insertions(+), 8 deletions(-)
> > 
> > diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_version.c b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_version.c
> []
> > @@ -33,27 +33,27 @@
> >  #include "vchiq_build_info.h"
> >  #include <linux/broadcom/vc_debug_sym.h>
> >  
> > -VC_DEBUG_DECLARE_STRING_VAR( vchiq_build_hostname, "dc4-arm-01" );
> > -VC_DEBUG_DECLARE_STRING_VAR( vchiq_build_version, "9245b4c35b99b3870e1f7dc598c5692b3c66a6f0 (tainted)" );
> > -VC_DEBUG_DECLARE_STRING_VAR( vchiq_build_time,    __TIME__ );
> > -VC_DEBUG_DECLARE_STRING_VAR( vchiq_build_date,    __DATE__ );
> > +VC_DEBUG_DECLARE_STRING_VAR(vchiq_build_hostname, "dc4-arm-01");
> > +VC_DEBUG_DECLARE_STRING_VAR(vchiq_build_version, "9245b4c35b99b3870e1f7dc598c5692b3c66a6f0 (tainted)");
> > +VC_DEBUG_DECLARE_STRING_VAR(vchiq_build_time,    __TIME__);
> > +VC_DEBUG_DECLARE_STRING_VAR(vchiq_build_date,    __DATE__);
> 
> Uses of __TIME__ and __DATE__ make it
> impossible to have repeatable builds.
> 
> Are these __TIME__ and __DATE__ uses
> really useful and necessary?

No, they need to be removed, but not in this patch :)

thanks,

greg k-h

Powered by blists - more mailing lists