linux-kernel - Re: [PATCH] drivers: net: xgene: Simplify xgene_enet_setup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20170224.142932.902090866869403269.davem@davemloft.net>
Date:   Fri, 24 Feb 2017 14:29:32 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     geert@...ux-m68k.org
Cc:     isubramanian@....com, kchudgar@....com, arnd@...db.de,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drivers: net: xgene: Simplify xgene_enet_setup_mss()
 to kill warning

From: Geert Uytterhoeven <geert@...ux-m68k.org>
Date: Fri, 24 Feb 2017 11:30:03 +0100

> With gcc-4.1.2 and -Os:
> 
>     drivers/net/ethernet/apm/xgene/xgene_enet_main.c: In function ‘xgene_enet_start_xmit’:
>     drivers/net/ethernet/apm/xgene/xgene_enet_main.c:297: warning: ‘mss_index’ may be used uninitialized in this function
> 
> Using a separate variable to track success may confuse the compiler.
> Preinitialize mss_index with -EBUSY and check for negative error values
> instead to kill the warning.
> 
> Signed-off-by: Geert Uytterhoeven <geert@...ux-m68k.org>

Applied, thank you.