linux-kernel - Re: [Outreachy kernel] Re: [PATCH v2 3/3] staging: rtl8192u: Prefer using the BIT macro

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.20.1702242145060.2152@hadrien>
Date:   Fri, 24 Feb 2017 21:46:07 +0100 (CET)
From:   Julia Lawall <julia.lawall@...6.fr>
To:     SIMRAN SINGHAL <singhalsimran0@...il.com>
cc:     outreachy-kernel <outreachy-kernel@...glegroups.com>,
        devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [Outreachy kernel] Re: [PATCH v2 3/3] staging: rtl8192u: Prefer
 using the BIT macro



On Fri, 24 Feb 2017, SIMRAN SINGHAL wrote:

>
>
> On Friday, February 24, 2017 at 10:46:21 PM UTC+5:30, gregkh wrote:
>       On Fri, Feb 17, 2017 at 11:20:59PM +0530, simran singhal wrote:
>       > Replaces left shift operation (1 << d) by BIT(x) macro.
>       >
>       > Fix the checkpatch.pl issue:
>       > CHECK: Prefer using the BIT macro replacing
>       >
>       > Signed-off-by: simran singhal <singhal...@...il.com>
>       > ---
>       >  
>       >  V2:
>       >    -modified patch message.
>       >
>       >  drivers/staging/rtl8192u/ieee80211/ieee80211.h | 140
>       ++++++++++++-------------
>       >  1 file changed, 70 insertions(+), 70 deletions(-)
>
>       The last chunk of this patch did not apply, please fix up and
>       resend.
>
>       thanks,
>
>       greg k-h
>
>
>   Can you please elaborate what's the problem with the last chunk of this
> patch and 
>   to be more precise what do you mean by "last chunk of this patch". I am
> not getting 
>   what's the problem with this patch.

I would say "hunk" rather than "chunk", but he probably means the code
from the last @@ @@ to the end.

The best thing is to just pull the most recent version of the kernel and
see what happens when you try to apply your patch.

julia