linux-kernel - Re: [PATCH] auxdisplay: img-ascii-lcd: add missing sentinel entry in img_ascii_lcd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2792939.Kfs5VkVaFl@np-p-burton>
Date:   Fri, 24 Feb 2017 13:56:41 -0800
From:   Paul Burton <paul.burton@...tec.com>
To:     Dmitry Torokhov <dmitry.torokhov@...il.com>,
        Ralf Baechle <ralf@...ux-mips.org>,
        James Hogan <james.hogan@...tec.com>
CC:     Miguel Ojeda Sandonis <miguel.ojeda.sandonis@...il.com>,
        <linux-kernel@...r.kernel.org>,
        Javier Martinez Canillas <javier@....samsung.com>
Subject: Re: [PATCH] auxdisplay: img-ascii-lcd: add missing sentinel entry in img_ascii_lcd_matches

Hi Dmitry,

On Monday, 20 February 2017 21:39:11 PST Dmitry Torokhov wrote:
> The OF device table must be terminated, otherwise we'll be walking past
> it and into areas unknown.
> 
> This causes KASAN errors reported by 0day kernel testing robot.
> 
> Reported-by: Fengguang Wu <fengguang.wu@...el.com>
> Tested-by: Fengguang Wu <fengguang.wu@...el.com>
> Fixes: 0cad855fbd08 ("auxdisplay: img-ascii-lcd: driver for simple
> ASCII...") Cc: stable@...r.kernel.org
> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@...il.com>

An essentially identical patch was already submitted over here:

https://patchwork.kernel.org/patch/9493973/

I'm not sure how it ought to get into mainline - since the driver went through 
the MIPS tree perhaps this fix can too?

Thanks,
    Paul

> ---
>  drivers/auxdisplay/img-ascii-lcd.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/auxdisplay/img-ascii-lcd.c
> b/drivers/auxdisplay/img-ascii-lcd.c index bf43b5d2aafc..83f1439e57fd
> 100644
> --- a/drivers/auxdisplay/img-ascii-lcd.c
> +++ b/drivers/auxdisplay/img-ascii-lcd.c
> @@ -218,6 +218,7 @@ static const struct of_device_id img_ascii_lcd_matches[]
> = { { .compatible = "img,boston-lcd", .data = &boston_config },
>  	{ .compatible = "mti,malta-lcd", .data = &malta_config },
>  	{ .compatible = "mti,sead3-lcd", .data = &sead3_config },
> +	{ /* sentinel */ }
>  };
> 
>  /**


Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)