linux-kernel - Re: [PATCH] ASoC: kirkwood: Add a blank line after declarations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.20.1702251419440.2179@hadrien>
Date:   Sat, 25 Feb 2017 14:20:48 +0100 (CET)
From:   Julia Lawall <julia.lawall@...6.fr>
To:     Anda-Alexandra Dorneanu <andadrn@...il.com>
cc:     perex@...ex.cz, tiwai@...e.com, lgirdwood@...il.com,
        broonie@...nel.org, Julia.Lawall@...6.fr,
        alsa-devel@...a-project.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ASoC: kirkwood: Add a blank line after declarations

On Sat, 25 Feb 2017, Anda-Alexandra Dorneanu wrote:

> From: andadrn <andadrn@...il.com>

Drop the From line.  The From line needs to match up with your Signed off
by line.  But the one generated by your mailer already does that, while
the one you added does not.

julia

>
> This was reported by checkpatch.pl
>
> Signed-off-by: Anda-Alexandra Dorneanu <andadrn@...il.com>
> ---
>  sound/soc/kirkwood/kirkwood-dma.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/sound/soc/kirkwood/kirkwood-dma.c b/sound/soc/kirkwood/kirkwood-dma.c
> index dafd22e..0af5d46 100644
> --- a/sound/soc/kirkwood/kirkwood-dma.c
> +++ b/sound/soc/kirkwood/kirkwood-dma.c
> @@ -24,6 +24,7 @@
>  static struct kirkwood_dma_data *kirkwood_priv(struct snd_pcm_substream *subs)
>  {
>  	struct snd_soc_pcm_runtime *soc_runtime = subs->private_data;
> +
>  	return snd_soc_dai_get_drvdata(soc_runtime->cpu_dai);
>  }
>
> @@ -91,6 +92,7 @@ static irqreturn_t kirkwood_dma_irq(int irq, void *dev_id)
>  	/* try to find matching cs for current dma address */
>  	for (i = 0; i < dram->num_cs; i++) {
>  		const struct mbus_dram_window *cs = dram->cs + i;
> +
>  		if ((cs->base & 0xffff0000) < (dma & 0xffff0000)) {
>  			writel(cs->base & 0xffff0000,
>  				base + KIRKWOOD_AUDIO_WIN_BASE_REG(win));
> --
> 1.9.1
>
>