linux-kernel - Re: [PATCH 0/3] fs: Support compiling out the pivot

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LFD.2.20.1702251013530.1766@knanqh.ubzr>
Date:   Sat, 25 Feb 2017 10:18:02 -0500 (EST)
From:   Nicolas Pitre <nicolas.pitre@...aro.org>
To:     Brian Ashworth <bosrsf04@...il.com>
cc:     Alexander Viro <viro@...iv.linux.org.uk>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Kees Cook <keescook@...omium.org>,
        Arnd Bergmann <arnd@...db.de>, Ingo Molnar <mingo@...nel.org>,
        Ard Biesheuvel <ard.biesheuvel@...aro.org>,
        Andy Lutomirski <luto@...nel.org>,
        Petr Mladek <pmladek@...e.com>, Helge Deller <deller@....de>,
        Rik van Riel <riel@...hat.com>,
        Thomas Garnier <thgarnie@...gle.com>,
        Parav Pandit <pandit.parav@...il.com>,
        "seokhoon . yoon" <iamyooon@...il.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        Dave Hansen <dave.hansen@...el.com>,
        linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org,
        josh@...htriplett.org, brkkurek192@...il.com, conorcurry@...il.com,
        fanofbond138@...il.com
Subject: Re: [PATCH 0/3] fs: Support compiling out the pivot_root syscall

On Fri, 24 Feb 2017, bosrsf04@...il.com wrote:

> From: Brian Ashworth <bosrsf04@...il.com>
> 
> This patch series will allow for the pivot_root syscall to be made
> optional. The first patch refactors the functions that are required
> by pivot_root so they can be accessed outside of fs/namespace.c. The
> second patch moves the pivot_root syscall to its own file. The third
> adds a Kconfig option and conditional compilation to the Makefile.
> 
> The pivot_root syscall is not needed on systems that do not use
> any intermediate filesystem. Allowing for pivot_root to be
> ommitted from the kernel will aid in the tinification efforts.

This looks good.  Every such tiny bits count, and besides the size 
reduction possibility this also makes the code clearer.

Acked-by: Nicolas Pitre <nico@...aro.org>

> Brian Ashworth (3):
>   Makes functions used by pivot_root accessible
>   Extracts pivot_root so it can be made optional
>   Allows for the pivot_root syscall to be omitted
> 
>  fs/Makefile     |   2 +
>  fs/mount.h      |  24 +++++++++
>  fs/namespace.c  | 150 +++-----------------------------------------------------
>  fs/pivot_root.c | 129 ++++++++++++++++++++++++++++++++++++++++++++++++
>  init/Kconfig    |  10 ++++
>  kernel/sys_ni.c |   1 +
>  6 files changed, 172 insertions(+), 144 deletions(-)
>  create mode 100644 fs/pivot_root.c
> 
> -- 
> 2.11.1
> 
>