linux-kernel - Re: [PATCH 2/3] fs: Extracts pivot

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170225160648.GQ29622@ZenIV.linux.org.uk>
Date:   Sat, 25 Feb 2017 16:06:49 +0000
From:   Al Viro <viro@...IV.linux.org.uk>
To:     Theodore Ts'o <tytso@....edu>, bosrsf04@...il.com,
        Andrew Morton <akpm@...ux-foundation.org>,
        Kees Cook <keescook@...omium.org>,
        Arnd Bergmann <arnd@...db.de>, Ingo Molnar <mingo@...nel.org>,
        Ard Biesheuvel <ard.biesheuvel@...aro.org>,
        Andy Lutomirski <luto@...nel.org>,
        Nicolas Pitre <nicolas.pitre@...aro.org>,
        Petr Mladek <pmladek@...e.com>, Helge Deller <deller@....de>,
        Rik van Riel <riel@...hat.com>,
        Thomas Garnier <thgarnie@...gle.com>,
        Parav Pandit <pandit.parav@...il.com>,
        "seokhoon . yoon" <iamyooon@...il.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        Dave Hansen <dave.hansen@...el.com>,
        linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org,
        josh@...htriplett.org, brkkurek192@...il.com, conorcurry@...il.com,
        fanofbond138@...il.com
Subject: Re: [PATCH 2/3] fs: Extracts pivot_root so it can be made optional

On Sat, Feb 25, 2017 at 10:22:21AM -0500, Theodore Ts'o wrote:
> If you're only going to be removing a single function, instead of
> having to export a bunch of previously-static functions, my preference
> would be to just insert a pair of #ifdef CONFIG_PIVOT_ROOT_SYSCALL / #endif
> statements around the function in question.

Quite.  In this form: NAK for the reasons above.