linux-kernel - Re: [PATCH] input: cpcap-pwrbutton: new driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170225192100.GK21809@atomide.com>
Date:   Sat, 25 Feb 2017 11:21:00 -0800
From:   Tony Lindgren <tony@...mide.com>
To:     Dmitry Torokhov <dmitry.torokhov@...il.com>
Cc:     Sebastian Reichel <sre@...nel.org>,
        Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        linux-input@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] input: cpcap-pwrbutton: new driver

* Dmitry Torokhov <dmitry.torokhov@...il.com> [170225 11:00]:
> On Fri, Feb 24, 2017 at 09:59:09AM +0100, Sebastian Reichel wrote:
> > +#include <linux/mfd/motorola-cpcap.h>
> > +
> > +#define CPCAP_IRQ_ON 23
> > +#define CPCAP_IRQ_ON_BITMASK (1 << (CPCAP_IRQ_ON % 16))
> 
> Is this truly static or it could depend= on IRQ returned by
> platform_get_irq()?

I suggest we add it to include/linux/mfd/motorola-cpcap.h:

static inline int cpcap_get_irq_status(struct device *dev,
				       struct regmap *regmap,
				       int irq,
				       u16 *status);

Or do you guys have better ideas?

I'll be needing that for the USB PHY driver too for multiple
bits so we want to return the whole bank register in status.

We may want to change to do that later to avoid dependencies
or set up an immutable branch with just that change.

Other than that things work for me based on a quick test.

Regards,

Tony