linux-kernel - Re: [PATCH] staging: bcm2835: Fix a memory leak in error handling path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170225041111.GB4429@mwanda>
Date:   Sat, 25 Feb 2017 07:11:11 +0300
From:   Dan Carpenter <dan.carpenter@...cle.com>
To:     Stefan Wahren <stefan.wahren@...e.com>
Cc:     lee@...nel.org, rjui@...adcom.com, linux-media@...r.kernel.org,
        eric@...olt.net, kernel-janitors@...r.kernel.org, arnd@...db.de,
        linux-arm-kernel@...ts.infradead.org, mchehab@...nel.org,
        Christophe JAILLET <christophe.jaillet@...adoo.fr>,
        sbranden@...adcom.com, gregkh@...uxfoundation.org,
        linux-kernel@...r.kernel.org,
        bcm-kernel-feedback-list@...adcom.com, devel@...verdev.osuosl.org,
        swarren@...dotorg.org, f.fainelli@...il.com,
        linux-rpi-kernel@...ts.infradead.org
Subject: Re: [PATCH] staging: bcm2835: Fix a memory leak in error handling
 path

On Fri, Feb 24, 2017 at 10:38:38PM +0100, Stefan Wahren wrote:
> 
> > Dan Carpenter <dan.carpenter@...cle.com> hat am 24. Februar 2017 um 20:57 geschrieben:
> > 
> > 
> > On Fri, Feb 24, 2017 at 01:37:30PM +0100, Stefan Wahren wrote:
> > > Hi Christophe,
> > > 
> > > Am 19.02.2017 um 11:34 schrieb Christophe JAILLET:
> > > >If 'kzalloc()' fails, we should release resources allocated so far, just as
> > > >done in all other cases in this function.
> > > >
> > > >Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr>
> > > >---
> > > >Not sure that the error handling path is correct.
> > > >Is 'gdev[0]' freed? Should it be?
> > > 
> > 
> > Yes, but I already sent a patch to fix this and your leak as well and
> > Greg merged it.
> 
> My leak? I'm confused.

The one you're fixing I mean.