linux-kernel - Re: [PATCH 1/1] Fixing coding guidelines in drivers/staging/android/ion/*

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sun, 26 Feb 2017 18:06:30 +0100
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     pjambhlekar <pushkar.iit@...il.com>
Cc:     Laura Abbott <labbott@...hat.com>,
        Sumit Semwal <sumit.semwal@...aro.org>,
        Arve Hjønnevåg <arve@...roid.com>,
        Riley Andrews <riandrews@...roid.com>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/1] Fixing coding guidelines in
 drivers/staging/android/ion/*

On Sun, Feb 26, 2017 at 10:24:02PM +0530, pjambhlekar wrote:
> Signed-off-by: pjambhlekar <pushkar.iit@...il.com>
> ---
>  drivers/staging/android/ion/ion-ioctl.c        | 2 +-
>  drivers/staging/android/ion/ion.c              | 8 ++++----
>  drivers/staging/android/ion/ion_cma_heap.c     | 3 +--
>  drivers/staging/android/ion/ion_dummy_driver.c | 2 +-
>  drivers/staging/android/ion/ion_system_heap.c  | 2 --
>  5 files changed, 7 insertions(+), 10 deletions(-)

How come you didn't read what my patch-bot sent you the last time you
sent me this patch?  Please fix up the problems it found last time and
resend if you wish for us to be able to review this patch (hint, I can't
take a path with no changelog text, and you forgot to use
get_maintainer.pl to find the correct mailing list to cc:).

Also, I need a "full" name in your from and signed-off-by line, unless
you really only use one word for when you sign legal documents?

Take your time, relax, fix things up, resend it to yourself first to
verify you got it all correct, and then you can send it to us.  Please
take at least a day to do this before resending, there is no rush.

thanks,

greg k-h