linux-kernel - Re: [Outreachy kernel] [PATCH] staging: bcm2835-audio: Fixed spacing around '&'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 26 Feb 2017 19:03:00 +0100 (CET)
From:   Julia Lawall <julia.lawall@...6.fr>
To:     Narcisa Ana Maria Vasile <narcisaanamaria12@...il.com>
cc:     swarren@...dotorg.org, lee@...nel.org, eric@...olt.net,
        f.fainelli@...il.com, rjui@...adcom.com, sbranden@...adcom.com,
        daniel.baluta@...mfreegmail.com, gregkh@...uxfoundation.org,
        outreachy-kernel@...glegroups.com,
        bcm-kernel-feedback-list@...adcom.com, mzoran@...wfest.net,
        danielperezdeandres@...il.com, dan.carpenter@...cle.com,
        devel@...verdev.osuosl.org, linux-rpi-kernel@...ts.infradead.org,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [Outreachy kernel] [PATCH] staging: bcm2835-audio: Fixed spacing
 around '&'



On Sun, 26 Feb 2017, Narcisa Ana Maria Vasile wrote:

> This was reported by checkpatch.pl
>
> Signed-off-by: Narcisa Ana Maria Vasile <narcisaanamaria12@...il.com>

Acked-by: Julia Lawall <julia.lawall@...6.fr>

Actually, the outreachy tutorial says not to send patches to mailing
lists, only to people (except in the case of IIO, where the maintainers
asked for patches to be sent to mailing lists as well).  The
get_maintainer command to use is shown here:

https://kernelnewbies.org/FirstKernelPatch#submit_a_patch

> ---
>  drivers/staging/bcm2835-audio/bcm2835-pcm.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/bcm2835-audio/bcm2835-pcm.c b/drivers/staging/bcm2835-audio/bcm2835-pcm.c
> index 9e79236..328bee4a 100644
> --- a/drivers/staging/bcm2835-audio/bcm2835-pcm.c
> +++ b/drivers/staging/bcm2835-audio/bcm2835-pcm.c
> @@ -91,7 +91,7 @@ void bcm2835_playback_fifo(struct bcm2835_alsa_stream *alsa_stream)
>  		frames_to_bytes(alsa_stream->substream->runtime, alsa_stream->substream->runtime->status->hw_ptr),
>  		new_period);
>  	if (alsa_stream->buffer_size) {
> -		alsa_stream->pos += consumed &~(1 << 30);
> +		alsa_stream->pos += consumed & ~(1 << 30);
>  		alsa_stream->pos %= alsa_stream->buffer_size;
>  	}
>
> --
> 1.9.1
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@...glegroups.com.
> To post to this group, send email to outreachy-kernel@...glegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/1488131271-2908-1-git-send-email-narcisaanamaria12%40gmail.com.
> For more options, visit https://groups.google.com/d/optout.
>