linux-kernel - Re: [PATCH v2 1/2] of: add devm_ functions for populate and depopulate

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170226201157.xzg5b5tyrdlxkeyd@phenom.ffwll.local>
Date:   Sun, 26 Feb 2017 21:11:57 +0100
From:   Daniel Vetter <daniel@...ll.ch>
To:     Rob Herring <robh+dt@...nel.org>
Cc:     Benjamin Gaignard <benjamin.gaignard@...aro.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linaro-kernel@...ts.linaro.org" <linaro-kernel@...ts.linaro.org>,
        Frank Rowand <frowand.list@...il.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        dri-devel <dri-devel@...ts.freedesktop.org>,
        Vincent Abriou <vincent.abriou@...com>
Subject: Re: [PATCH v2 1/2] of: add devm_ functions for populate and
 depopulate

On Fri, Feb 24, 2017 at 10:31:25AM -0600, Rob Herring wrote:
> On Fri, Feb 24, 2017 at 10:14 AM, Benjamin Gaignard
> <benjamin.gaignard@...aro.org> wrote:
> > Lots of calls to of_platform_populate() are not unbalanced by a call
> > to of_platform_depopulate(). This create issues while drivers are
> > bind/unbind.
> >
> > In way to solve those issues is to add devm_of_platform_populate()
> > which will call of_platform_depopulate() when the device is unbound
> > from the bus.
> >
> > Signed-off-by: Benjamin Gaignard <benjamin.gaignard@...aro.org>
> > ---
> > version 2:
> > - simplify function prototype to only keep device as parameter
> >
> >  drivers/of/platform.c       | 71 +++++++++++++++++++++++++++++++++++++++++++++
> >  include/linux/of_platform.h | 11 +++++++
> >  2 files changed, 82 insertions(+)
> 
> For this and patch 2:
> 
> Acked-by: Rob Herring <robh@...nel.org>

Is this an ack for merging both through drm-misc, or should we do a
topic-branch dance here?

/me not sure anymore what we discussed here already

Cheers, Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch