linux-kernel - RE: [PATCH] scsi: aacraid: remove redundant zero check on ret

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <423FD6710FB8FB4F8728F93591889F9A4EF434A6@avsrvexchmbx1.microsemi.net>
Date:   Sun, 26 Feb 2017 20:01:22 +0000
From:   Dave Carroll <david.carroll@...rosemi.com>
To:     Colin King <colin.king@...onical.com>,
        dl-esc-Aacraid Linux Driver <aacraid@...rosemi.com>,
        "James E . J . Bottomley" <jejb@...ux.vnet.ibm.com>,
        "Martin K . Petersen" <martin.petersen@...cle.com>,
        "linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>
CC:     "kernel-janitors@...r.kernel.org" <kernel-janitors@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] scsi: aacraid: remove redundant zero check on ret

> -----Original Message-----
> From: Colin King [mailto:colin.king@...onical.com]
> Sent: Friday, February 24, 2017 7:44 AM
> To: dl-esc-Aacraid Linux Driver; James E . J . Bottomley; Martin K .
> Petersen; linux-scsi@...r.kernel.org
> Cc: kernel-janitors@...r.kernel.org; linux-kernel@...r.kernel.org
> Subject: [PATCH] scsi: aacraid: remove redundant zero check on ret
> 
> From: Colin Ian King <colin.king@...onical.com>
> 
> The check for ret being zero is redundant as a few statements earlier we
> break out of the while loop if ret is non-zero.  Thus we can remove the
> zero check and also the dead-code non-zero case too.
> 
> Detected by CoverityScan, CID#1411632 ("Logically Dead Code")
> 
> Signed-off-by: Colin Ian King <colin.king@...onical.com>
> ---
>  drivers/scsi/aacraid/commsup.c | 6 +-----
>  1 file changed, 1 insertion(+), 5 deletions(-)

Acked-by: Dave Carroll <david.carroll@...rosemi.com>