linux-kernel - Re: [PATCH v2 2/5] KVM: add KVM request variants without barrier

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <969967af-8acd-4c63-ee69-a453112d8434@redhat.com>
Date:   Mon, 27 Feb 2017 11:18:23 +0100
From:   David Hildenbrand <david@...hat.com>
To:     Radim Krčmář <rkrcmar@...hat.com>,
        linux-kernel@...r.kernel.org, kvm@...r.kernel.org
Cc:     Paolo Bonzini <pbonzini@...hat.com>,
        Andrew Jones <drjones@...hat.com>,
        Marc Zyngier <marc.zyngier@....com>,
        Christian Borntraeger <borntraeger@...ibm.com>,
        Cornelia Huck <cornelia.huck@...ibm.com>,
        James Hogan <james.hogan@...tec.com>,
        Paul Mackerras <paulus@...abs.org>,
        Christoffer Dall <christoffer.dall@...aro.org>
Subject: Re: [PATCH v2 2/5] KVM: add KVM request variants without barrier

Am 27.02.2017 um 11:02 schrieb David Hildenbrand:
> Am 24.02.2017 um 20:49 schrieb Radim Krčmář:
>> The leading underscores denote that the call is just a bitop wrapper.
> 
> Actually, the leading underscore is misleading
> 
> If we want to match the semantics of set/test/clear_bit, using a leading
> underscore might feel like using the non-atomic variants like
> __clear_bit and friends.
> 
> I'd prefer to simply drop the underscore.
> 

Okay, this is not really possible for __kvm_request_set(). Hm.....

-- 
Thanks,

David