linux-kernel - Re: [PATCH v4 2/6] staging: ks7010: fix coding style issue of enclosing complex macro value in parentheses

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 27 Feb 2017 15:46:27 +0100
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Chetan Sethi <cpsethi369@...il.com>
Cc:     devel@...verdev.osuosl.org, punitvara@...il.com, wsa@...-dreams.de,
        linux-kernel@...r.kernel.org, shiva@...ev.nl
Subject: Re: [PATCH v4 2/6] staging: ks7010: fix coding style issue of
 enclosing complex macro value in parentheses

On Sun, Feb 26, 2017 at 04:01:22PM +0900, Chetan Sethi wrote:
> This patch fixes error of enclosing complex macro value in parentheses,
> error as issued by checkpatch
> 
> Signed-off-by: Chetan Sethi <cpsethi369@...il.com>
> ---
> v2:
>  - split multiple changes across different patches
> v3:
>  - mentioned patch revision in subject
>  - incorporated review comment of correct indentation for do statement
> v4:
>  - modified description to exclude mention of patch number from changelog
> 
>  drivers/staging/ks7010/ks_wlan.h | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/ks7010/ks_wlan.h b/drivers/staging/ks7010/ks_wlan.h
> index 668202d..33d6b28 100644
> --- a/drivers/staging/ks7010/ks_wlan.h
> +++ b/drivers/staging/ks7010/ks_wlan.h
> @@ -36,8 +36,10 @@
>  
>  #ifdef KS_WLAN_DEBUG
>  #define DPRINTK(n, fmt, args...) \
> -                 if (KS_WLAN_DEBUG > (n)) \
> -			printk(KERN_NOTICE "%s: "fmt, __FUNCTION__, ## args)
> +        do { \

This line is not correct, again, it's ok if existing code has checkpatch
issues, but you should never _add_ any new ones.

Please fix this up and resend the series.

thanks,

greg k-h