linux-kernel - Re: [PATCH -next] ASoC: hdmi-codec: fix non static symbol warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 27 Feb 2017 10:08:15 +0900
From:   Takashi Sakamoto <o-takashi@...amocchi.jp>
To:     Wei Yongjun <weiyj.lk@...il.com>,
        Liam Girdwood <lgirdwood@...il.com>,
        Mark Brown <broonie@...nel.org>,
        Jaroslav Kysela <perex@...ex.cz>,
        Takashi Iwai <tiwai@...e.com>,
        Philipp Zabel <p.zabel@...gutronix.de>,
        "Jon Medhurst (Tixy)" <tixy@...aro.org>,
        Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>,
        Arnaud Pouliquen <arnaud.pouliquen@...com>,
        Jyri Sarha <jsarha@...com>, PC Liao <pc.liao@...iatek.com>
Cc:     alsa-devel@...a-project.org, Wei Yongjun <weiyongjun1@...wei.com>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH -next] ASoC: hdmi-codec: fix non static symbol warnings

Hi,

On Feb 6 2017 23:38, Wei Yongjun wrote:
> From: Wei Yongjun <weiyongjun1@...wei.com>
>
> Fixes the following sparse warnings:
>
> sound/soc/codecs/hdmi-codec.c:34:1: warning:
>  symbol 'hdmi_device_list' was not declared. Should it be static?
> sound/soc/codecs/hdmi-codec.c:80:33: warning:
>  symbol 'hdmi_codec_stereo_chmaps' was not declared. Should it be static?
> sound/soc/codecs/hdmi-codec.c:87:33: warning:
>  symbol 'hdmi_codec_8ch_chmaps' was not declared. Should it be static?
> sound/soc/codecs/hdmi-codec.c:354:6: warning:
>  symbol 'hdmi_codec_eld_chmap' was not declared. Should it be static?
>
> Signed-off-by: Wei Yongjun <weiyongjun1@...wei.com>
> ---
>  sound/soc/codecs/hdmi-codec.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)

Reviewed-by: Takashi Sakamoto <o-takashi@...amocchi.jp>

Unfortunately, this patch causes conflict to Mark's PR[0], due to a 
commit 8480ac567959 ("ASoC: hdmi-codec: remove HDMI device 
unregister")[1]. I think it better for you to post again with rebasing 
this on the PR, however it depends on Mark's maintenance policy (he 
could resolve the conflict by his hand and apply).

[0] 
http://mailman.alsa-project.org/pipermail/alsa-devel/2017-February/118079.html
[1] 
https://git.kernel.org/cgit/linux/kernel/git/tiwai/sound.git/commit/?id=8480ac567959

> diff --git a/sound/soc/codecs/hdmi-codec.c b/sound/soc/codecs/hdmi-codec.c
> index dc6715a..4982c91 100644
> --- a/sound/soc/codecs/hdmi-codec.c
> +++ b/sound/soc/codecs/hdmi-codec.c
> @@ -31,7 +31,7 @@ struct hdmi_device {
>  	int cnt;
>  };
>  #define pos_to_hdmi_device(pos)	container_of((pos), struct hdmi_device, list)
> -LIST_HEAD(hdmi_device_list);
> +static LIST_HEAD(hdmi_device_list);
>
>  #define DAI_NAME_SIZE 16
>
> @@ -77,14 +77,14 @@ struct hdmi_codec_cea_spk_alloc {
>  };
>
>  /* Channel maps  stereo HDMI */
> -const struct snd_pcm_chmap_elem hdmi_codec_stereo_chmaps[] = {
> +static const struct snd_pcm_chmap_elem hdmi_codec_stereo_chmaps[] = {
>  	{ .channels = 2,
>  	  .map = { SNDRV_CHMAP_FL, SNDRV_CHMAP_FR } },
>  	{ }
>  };
>
>  /* Channel maps for multi-channel playbacks, up to 8 n_ch */
> -const struct snd_pcm_chmap_elem hdmi_codec_8ch_chmaps[] = {
> +static const struct snd_pcm_chmap_elem hdmi_codec_8ch_chmaps[] = {
>  	{ .channels = 2, /* CA_ID 0x00 */
>  	  .map = { SNDRV_CHMAP_FL, SNDRV_CHMAP_FR } },
>  	{ .channels = 4, /* CA_ID 0x01 */
> @@ -351,7 +351,7 @@ static unsigned long hdmi_codec_spk_mask_from_alloc(int spk_alloc)
>  	return spk_mask;
>  }
>
> -void hdmi_codec_eld_chmap(struct hdmi_codec_priv *hcp)
> +static void hdmi_codec_eld_chmap(struct hdmi_codec_priv *hcp)
>  {
>  	u8 spk_alloc;
>  	unsigned long spk_mask;


Thanks

Takashi Sakamoto