linux-kernel - Re: [PATCH 5/9] Staging: rtl8712: rtl871x_mp_ioctl.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170227142247.GA16503@kroah.com>
Date:   Mon, 27 Feb 2017 15:22:47 +0100
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Derek Robson <robsonde@...il.com>
Cc:     Larry.Finger@...inger.net, florian.c.schilhabel@...glemail.com,
        binoy.jayan@...aro.org, arnd@...db.de, bhumirks@...il.com,
        shaily15297@...oo.com, raphael.beamonte@...il.com,
        becher.jannik@...il.com, devel@...verdev.osuosl.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 5/9] Staging: rtl8712: rtl871x_mp_ioctl.h - style fix

On Sun, Feb 26, 2017 at 03:32:08PM +1300, Derek Robson wrote:
> Fixed style of block comments
> Found using checkpatch
> 
> Signed-off-by: Derek Robson <robsonde@...il.com>
> ---
>  drivers/staging/rtl8712/rtl871x_mp_ioctl.h | 32 +++++++++++++++---------------
>  1 file changed, 16 insertions(+), 16 deletions(-)
> 
> diff --git a/drivers/staging/rtl8712/rtl871x_mp_ioctl.h b/drivers/staging/rtl8712/rtl871x_mp_ioctl.h
> index 1102451a733d..c99a6dbae476 100644
> --- a/drivers/staging/rtl8712/rtl871x_mp_ioctl.h
> +++ b/drivers/staging/rtl8712/rtl871x_mp_ioctl.h
> @@ -162,26 +162,26 @@ static const struct oid_obj_priv oid_rtl_seg_81_80_00[] = {
>  					 */
>  	{1, oid_rt_pro_set_channel_direct_call_hdl},	/*0x08*/
>  	{1, oid_null_function},		/*0x09
> -				* OID_RT_PRO_SET_SLEEP_MODE_DIRECT_CALL
> -				*/
> +					 * OID_RT_PRO_SET_SLEEP_MODE_DIRECT_CALL
> +					 */
>  	{1, oid_null_function},		/*0x0A
> -				* OID_RT_PRO_SET_WAKE_MODE_DIRECT_CALL
> -				*/
> +					 * OID_RT_PRO_SET_WAKE_MODE_DIRECT_CALL
> +					 */
>  	{1, oid_rt_pro_set_continuous_tx_hdl},	/*0x0B
> -				* OID_RT_PRO_SET_TX_CONTINUOUS_DIRECT_CALL
> -				*/
> +						 * OID_RT_PRO_SET_TX_CONTINUOUS_DIRECT_CALL

Now you are going out beyond 80 columns, which is what caused someone to
move the comment to the left earlier :(

Just put the comment in a single line, above the data definition, like
this:
	/* 0x0B OID_RT_PRO_SET_TX_CONTINUOUS_DIRECT_CALL */
 	{1, oid_rt_pro_set_continuous_tx_hdl},

Which makes it easier for everyone to read and understand, which is the
main goal of cleaning up code.

thanks,

greg k-h