linux-kernel - Re: [PATCH] tracing: Fix code comment for ftrace_ops_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170227110841.12fff548@gandalf.local.home>
Date:   Mon, 27 Feb 2017 11:08:41 -0500
From:   Steven Rostedt <rostedt@...dmis.org>
To:     Chunyu Hu <chuhu@...hat.com>
Cc:     mingo@...nel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] tracing: Fix code comment for ftrace_ops_get_func

On Wed, 22 Feb 2017 08:29:26 +0800
Chunyu Hu <chuhu@...hat.com> wrote:

> There is no function 'ftrace_ops_recurs_func' existing in the code, it
> should be ftrace_ops_assist_func. Fix the comment to avoid misleading.

Applied, thanks!

I'm not sure it will go in this merge window. It might, I'll have to
see what else there is.

-- Steve

> 
> Signed-off-by: Chunyu Hu <chuhu@...hat.com>
> ---
>  kernel/trace/ftrace.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/kernel/trace/ftrace.c b/kernel/trace/ftrace.c
> index 0c06093..fd84f2e 100644
> --- a/kernel/trace/ftrace.c
> +++ b/kernel/trace/ftrace.c
> @@ -5487,7 +5487,7 @@ static void ftrace_ops_assist_func(unsigned long ip, unsigned long parent_ip,
>   * Normally the mcount trampoline will call the ops->func, but there
>   * are times that it should not. For example, if the ops does not
>   * have its own recursion protection, then it should call the
> - * ftrace_ops_recurs_func() instead.
> + * ftrace_ops_assist_func() instead.
>   *
>   * Returns the function that the trampoline should call for @ops.
>   */