linux-kernel - Re: [PATCH] hlist_add_tail

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170227134036.2134852c@gandalf.local.home>
Date:   Mon, 27 Feb 2017 13:40:36 -0500
From:   Steven Rostedt <rostedt@...dmis.org>
To:     "Michael S. Tsirkin" <mst@...hat.com>
Cc:     linux-kernel@...r.kernel.org,
        "Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>,
        Josh Triplett <josh@...htriplett.org>,
        Mathieu Desnoyers <mathieu.desnoyers@...icios.com>,
        Lai Jiangshan <jiangshanlai@...il.com>,
        David Miller <davem@...emloft.net>
Subject: Re: [PATCH] hlist_add_tail_rcu disable sparse warning

On Fri, 10 Feb 2017 19:39:49 +0200
"Michael S. Tsirkin" <mst@...hat.com> wrote:

> diff --git a/include/linux/rculist.h b/include/linux/rculist.h
> index 4f7a956..bf578e8 100644
> --- a/include/linux/rculist.h
> +++ b/include/linux/rculist.h
> @@ -509,7 +509,7 @@ static inline void hlist_add_tail_rcu(struct hlist_node *n,
>  {
>  	struct hlist_node *i, *last = NULL;
>  
> -	for (i = hlist_first_rcu(h); i; i = hlist_next_rcu(i))
> +	for (i = h->first; i; i = i->next)

Looks good to me, but I would probably add a comment above the loop
about this being in a write side section, and rcu conversions are not
needed.

Reviewed-by: Steven Rostedt (VMware) <rostedt@...dmis.org>

-- Steve

>  		last = i;
>  
>  	if (last) {