[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20170227202915.GA10862@eros>
Date: Tue, 28 Feb 2017 07:29:15 +1100
From: "Tobin C. Harding" <me@...in.cc>
To: Julia Lawall <julia.lawall@...6.fr>
Cc: Arushi Singhal <arushisinghal19971997@...il.com>,
devel@...verdev.osuosl.org, Greg KH <gregkh@...uxfoundation.org>,
linux-kernel@...r.kernel.org, outreachy-kernel@...glegroups.com
Subject: Re: [Outreachy kernel] Re: [PATCH v2] staging: ks7010: remove code
in comments.
On Mon, Feb 27, 2017 at 04:07:27PM +0100, Julia Lawall wrote:
>
>
> On Mon, 27 Feb 2017, Arushi Singhal wrote:
>
> >
> >
> > On Mon, Feb 27, 2017 at 8:18 PM, Greg KH <gregkh@...uxfoundation.org> wrote:
> > On Sun, Feb 26, 2017 at 09:38:20PM +0530, Arushi Singhal wrote:
> > > Commenting Code Is a Bad Idea.
> > > Comments are their to explain the code and how the code
> > achieves its
> > > goal and as codes in the comments does not explain what the
> > code is
> > > doing so there is no use of commenting them.
> > > So in this patch codes in the comments are removed.
> > >
> > > Signed-off-by: Arushi Singhal
> > <arushisinghal19971997@...il.com>
> > > ---
> > > changes in v2
> > > - subject lines is made short.
> > >
> > > drivers/staging/ks7010/ks7010_sdio.c | 4 ----
> > > 1 file changed, 4 deletions(-)
> >
> > This patch does not apply against my staging-testing branch :(
> >
> >
> > why?
>
> You should figure this out yourself. Pull Greg's tree again, and try to
> apply your patch. It's deterministic, so you should have the same
> information that he has.
I have only just worked this out Arushi so I thought I'd share. You
may want to read up on remote tracking branches in git and set up a
branch tracking Greg's staging-testing branch. Then create (checkout
-b) your development branches from that branch.
Good luck,
Tobin.
Powered by blists - more mailing lists