linux-kernel - RE: [PATCH] IB/qib: fix false-postive maybe-uninitialized warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2807E5FD2F6FDA4886F6618EAC48510E67C59B29@CRSMSX101.amr.corp.intel.com>
Date:   Mon, 27 Feb 2017 21:22:45 +0000
From:   "Weiny, Ira" <ira.weiny@...el.com>
To:     Arnd Bergmann <arnd@...db.de>, infinipath <infinipath@...el.com>,
        "Doug Ledford" <dledford@...hat.com>,
        "Hefty, Sean" <sean.hefty@...el.com>,
        "Hal Rosenstock" <hal.rosenstock@...il.com>
CC:     "Dalessandro, Dennis" <dennis.dalessandro@...el.com>,
        Leon Romanovsky <leon@...nel.org>,
        "Chegondi, Harish" <harish.chegondi@...el.com>,
        "Masahiro Yamada" <yamada.masahiro@...ionext.com>,
        "John, Jubin" <jubin.john@...el.com>,
        "linux-rdma@...r.kernel.org" <linux-rdma@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] IB/qib: fix false-postive maybe-uninitialized warning

> 
> aarch64-linux-gcc-7 complains about code it doesn't fully understand:
> 
> drivers/infiniband/hw/qib/qib_iba7322.c: In function
> 'qib_7322_txchk_change':
> include/asm-generic/bitops/non-atomic.h:105:35: error: 'shadow' may be used
> uninitialized in this function [-Werror=maybe-uninitialized]
> 
> The code is right, and despite trying hard, I could not come up with a version
> that I liked better than just adding a fake initialization here to shut up the
> warning.
> 
> Fixes: f931551bafe1 ("IB/qib: Add new qib driver for QLogic PCIe InfiniBand
> adapters")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> ---

Sounds reasonable to me.

Acked-by: Ira Weiny <ira.weiny@...el.com>

>  drivers/infiniband/hw/qib/qib_iba7322.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/infiniband/hw/qib/qib_iba7322.c
> b/drivers/infiniband/hw/qib/qib_iba7322.c
> index 12c4208fd701..af9f596bb68b 100644
> --- a/drivers/infiniband/hw/qib/qib_iba7322.c
> +++ b/drivers/infiniband/hw/qib/qib_iba7322.c
> @@ -7068,7 +7068,7 @@ static void qib_7322_txchk_change(struct
> qib_devdata *dd, u32 start,
>  	unsigned long flags;
> 
>  	while (wait) {
> -		unsigned long shadow;
> +		unsigned long shadow = 0;
>  		int cstart, previ = -1;
> 
>  		/*
> --
> 2.9.0