linux-kernel - Re: [REGRESSION] pinctrl, of, unable to find hogs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170227210639.pxkcafpitacb6uwj@t450s.lan>
Date:   Mon, 27 Feb 2017 22:06:39 +0100
From:   Gary Bisson <gary.bisson@...ndarydevices.com>
To:     Tony Lindgren <tony@...mide.com>
Cc:     Mika Penttilä <mika.penttila@...tfour.com>,
        LKML <linux-kernel@...r.kernel.org>, linus.walleij@...aro.org
Subject: Re: [REGRESSION] pinctrl, of, unable to find hogs

Hi Tony,

On Mon, Feb 27, 2017 at 10:45:35AM -0800, Tony Lindgren wrote:
> * Tony Lindgren <tony@...mide.com> [170227 09:37]:
> > * Gary Bisson <gary.bisson@...ndarydevices.com> [170227 08:42]:
> > > > Not sure how to fix it though since we can't move the dt probing before
> > > > radix tree init.
> > 
> > Yup looks like we still have an issue with pinctrl driver functions
> > getting called before driver probe has completed.
> > 
> > How about we introduce something like:
> > 
> > int pinctrl_claim_hogs(struct pinctrl_dev *pctldev);
> > 
> > Then the drivers can call that at the end of the probe after
> > the pins have been parsed?
> > 
> > This should be safe as no other driver can claim the pins either
> > before the pins have been parsed :)
> 
> Below is an initial take on this solution. I've only briefly tested
> it so far but maybe give it a try and see if it helps.
> 
> I'll take a look if we can make the error handling better for
> pinctrl_register_and_init().

I'll try that tomorrow morning and let you know.

Regards,
Gary