linux-kernel - Re: [PATCH RESEND] checkpatch: remove obsolete CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 27 Feb 2017 15:04:46 -0800
From:   Joe Perches <joe@...ches.com>
To:     Ruslan Bilovol <ruslan.bilovol@...il.com>, apw@...onical.com,
        Andrew Morton <akpm@...ux-foundation.org>
Cc:     linux-kernel@...r.kernel.org, keescook@...omium.org
Subject: Re: [PATCH RESEND] checkpatch: remove obsolete CONFIG_EXPERIMENTAL
 checks

On Tue, 2017-02-28 at 00:21 +0200, Ruslan Bilovol wrote:
> Config EXPERIMENTAL has been removed from kernel in 2013
> (see 3d374d0: "final removal of CONFIG_EXPERIMENTAL"),
> there is no any reason to do these checks now.

> Signed-off-by: Ruslan Bilovol <ruslan.bilovol@...il.com>

While I think all the defconfigs that have CONFIG_EXPERIMENTAL
should have those lines removed, this seems sensible enough.

$ git grep -w CONFIG_EXPERIMENTAL -- "*defconfig*" | wc -l
216

Acked-by: Joe Perches <joe@...ches.com>

Here's a little script to remove the CONFIG_EXPERIMENTAL
lines from all the defconfigs too:

$ git grep -w --name-only CONFIG_EXPERIMENTAL -- "*defconfig*" | \
  xargs sed -i -e '/CONFIG_EXPERIMENTAL=[yn]/d'

> ---
>  scripts/checkpatch.pl | 13 -------------
>  1 file changed, 13 deletions(-)
> 
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index 982c52c..e0a34e6 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -2746,13 +2746,6 @@ sub process {
>  			#print "is_start<$is_start> is_end<$is_end> length<$length>\n";
>  		}
>  
> -# discourage the addition of CONFIG_EXPERIMENTAL in Kconfig.
> -		if ($realfile =~ /Kconfig/ &&
> -		    $line =~ /.\s*depends on\s+.*\bEXPERIMENTAL\b/) {
> -			WARN("CONFIG_EXPERIMENTAL",
> -			     "Use of CONFIG_EXPERIMENTAL is deprecated. For alternatives, see https://lkml.org/lkml/2012/10/23/580\n");
> -		}
> -
>  # discourage the use of boolean for type definition attributes of Kconfig options
>  		if ($realfile =~ /Kconfig/ &&
>  		    $line =~ /^\+\s*\bboolean\b/) {
> @@ -3146,12 +3139,6 @@ sub process {
>  			}
>  		}
>  
> -# discourage the addition of CONFIG_EXPERIMENTAL in #if(def).
> -		if ($line =~ /^\+\s*\#\s*if.*\bCONFIG_EXPERIMENTAL\b/) {
> -			WARN("CONFIG_EXPERIMENTAL",
> -			     "Use of CONFIG_EXPERIMENTAL is deprecated. For alternatives, see https://lkml.org/lkml/2012/10/23/580\n");
> -		}
> -
>  # check for RCS/CVS revision markers
>  		if ($rawline =~ /^\+.*\$(Revision|Log|Id)(?:\$|)/) {
>  			WARN("CVS_KEYWORD",