linux-kernel - Re: [PATCH 2/3] spi: allocate spi_board

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170228041134.GA9838@dtor-ws>
Date:   Mon, 27 Feb 2017 20:11:34 -0800
From:   Dmitry Torokhov <dmitry.torokhov@...il.com>
To:     Mark Brown <broonie@...nel.org>
Cc:     linux-spi@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/3] spi: allocate spi_board_info entries one by one

On Mon, Feb 27, 2017 at 08:08:47PM -0800, Dmitry Torokhov wrote:
> Lists of spi_board_info entries registered with spi_register_board_info()
> can be quite long; instead of forcing memory allocator find contagious
> chunk of memory, let;s allocate them one-by-one, so they can be packed as
> needed.
> 
> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@...il.com>
> ---
>  drivers/spi/spi.c | 11 +++++------
>  1 file changed, 5 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/spi/spi.c b/drivers/spi/spi.c
> index b948d8cdbace..029864410a5f 100644
> --- a/drivers/spi/spi.c
> +++ b/drivers/spi/spi.c
> @@ -686,14 +686,13 @@ int spi_register_board_info(struct spi_board_info const *info, unsigned n)
>  	if (!n)
>  		return -EINVAL;
>  
> -	bi = kzalloc(n * sizeof(*bi), GFP_KERNEL);
> -	if (!bi)
> -		return -ENOMEM;
> -
> -	for (i = 0; i < n; i++, bi++, info++) {
> +	for (i = 0; i < n; i++, info++) {
>  		struct spi_master *master;
>  
> -		memcpy(&bi->board_info, info, sizeof(*info));
> +		bi = kmemdup(info, sizeof(*bi), GFP_KERNEL);

Meh, should not have changed to kmemdup at the 11th hour: different
types. I'll send v2 in a minute.

> +		if (!bi)
> +			return -ENOMEM;
> +
>  		bi->board_info.properties =
>  			property_entries_dup(info->properties);
>  		if (IS_ERR(bi->board_info.properties))
> -- 
> 2.11.0.483.g087da7b7c-goog
> 

-- 
Dmitry