linux-kernel - Re: [PATCH] jump_label: align jump

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <510FF566-011D-4199-86F7-2BB4DBF36434@linux.vnet.ibm.com>
Date:   Tue, 28 Feb 2017 10:25:46 +0530
From:   Sachin Sant <sachinp@...ux.vnet.ibm.com>
To:     Jason Baron <jbaron@...mai.com>
Cc:     David Daney <ddaney@...iumnetworks.com>,
        Steven Rostedt <rostedt@...dmis.org>,
        linux-mips@...ux-mips.org, Chris Metcalf <cmetcalf@...lanox.com>,
        LKML <linux-kernel@...r.kernel.org>,
        Ralf Baechle <ralf@...ux-mips.org>,
        Russell King <linux@...linux.org.uk>,
        Rabin Vincent <rabin@....in>,
        Paul Mackerras <paulus@...ba.org>,
        Anton Blanchard <anton@...ba.org>,
        linuxppc-dev@...ts.ozlabs.org, Ingo Molnar <mingo@...nel.org>,
        linux-arm-kernel@...ts.infradead.org, Zhigang Lu <zlu@...hip.com>,
        Michael Ellerman <mpe@...erman.id.au>
Subject: Re: [PATCH] jump_label: align jump_entry table to at least 4-bytes


> Thanks for the suggestion! I would like to see if this resolves the ppc issue we had. I'm attaching a powerpc patch based on your suggestion. Hopefully, Sachin can try it.
> 
> Thanks,
> 

I tried this patch. It does not fix the warning. 

[   11.709071] mount (2956) used greatest stack depth: 10176 bytes left
[   11.731883] ------------[ cut here ]------------
[   11.731911] WARNING: CPU: 3 PID: 2972 at kernel/jump_label.c:287 static_key_set_entries.isra.10+0x3c/0x50
[   11.731915] Modules linked in: nfsd(+) ip_tables x_tables autofs4
[   11.731925] CPU: 3 PID: 2972 Comm: modprobe Not tainted 4.10.0-next-20170227 #4
[   11.731930] task: c00000077b284a00 task.stack: c00000077b8b8000
[   11.731933] NIP: c0000000017bf84c LR: c0000000017bfcbc CTR: 0000000000000000
[   11.731937] REGS: c00000077b8bb800 TRAP: 0700   Not tainted  (4.10.0-next-20170227)
[   11.731940] MSR: 800000000282b033 <SF,VEC,VSX,EE,FP,ME,IR,DR,RI,LE>
[   11.731948]   CR: 48248282  XER: 00000001
[   11.731953] CFAR: c0000000017bf81c SOFTE: 1 
GPR00: c0000000017bfc7c c00000077b8bba80 c00000000266c300 d0000000063e28f8 
GPR04: d0000000063e5b57 0000000100000017 c0000000017bf5a0 0000000000000000 
GPR08: 0000000000052eb3 0000000000000001 c00000000258c300 0000000000000001 
GPR12: c000000001b5b460 c00000000ea80c00 0000000000000020 d000000006380bb0 
GPR16: c00000077b8bbda0 c00000077b8bbdec 0000000000000000 0000000000008580 
GPR20: d000000006410000 d0000000063e7ea8 c00000000256db90 0000000000000001 
GPR24: c00000000258ca14 0000000000000000 c0000000025737f8 d0000000063e5c17 
GPR28: 0000000000000000 d0000000063e6780 d0000000063e28f0 d0000000063e5b57 
[   11.732000] NIP [c0000000017bf84c] static_key_set_entries.isra.10+0x3c/0x50
[   11.732004] LR [c0000000017bfcbc] jump_label_module_notify+0x20c/0x420
[   11.732007] Call Trace:
[   11.732011] [c00000077b8bba80] [c0000000017bfc7c] jump_label_module_notify+0x1cc/0x420 (unreliable)
[   11.732019] [c00000077b8bbb40] [c0000000016b69b0] notifier_call_chain+0x90/0x100
[   11.732024] [c00000077b8bbb90] [c0000000016b6e80] __blocking_notifier_call_chain+0x60/0x90
[   11.732029] [c00000077b8bbbe0] [c0000000017380ec] load_module+0x1c2c/0x2760
[   11.732034] [c00000077b8bbd70] [c000000001738e80] SyS_finit_module+0xc0/0xf0
[   11.732040] [c00000077b8bbe30] [c0000000015cb8e0] system_call+0x38/0xfc
[   11.732043] Instruction dump:
[   11.732046] 40c20018 e9230000 792907a0 7c844b78 f8830000 4e800020 3d42fff2 892a0714 
[   11.732053] 2f890000 40feffe0 39200001 992a0714 <0fe00000> 4bffffd0 60000000 60000000 
[   11.732061] ---[ end trace 13c67d418143453c ]---
[   11.732319] Installing knfsd (copyright (C) 1996 okir@...ad.swb.de).

I have collected the o/p of the command suggested by David. Here is a snippet from the run

File: ./arch/powerpc/kernel/built-in.o
  [383] __jump_table      PROGBITS        0000000000000000 068020 000c78 18 WAM  0   0  1
File: ./arch/powerpc/kernel/rtasd.o
File: ./arch/powerpc/kernel/of_platform.o
File: ./arch/powerpc/kernel/eeh_event.o
File: ./arch/powerpc/kernel/setup_64.o
  [18] __jump_table      PROGBITS        0000000000000000 001240 000048 18 WAM  0   0  1
File: ./arch/powerpc/kernel/rtas-proc.o
File: ./arch/powerpc/kernel/signal_64.o
  [13] __jump_table      PROGBITS        0000000000000000 001c68 000060 18 WAM  0   0  1

Have attached the complete o/p here for reference.

Thanks
-Sachin


Download attachment "jump_table.log" of type "application/octet-stream" (140509 bytes)