linux-kernel - Re: [RFC 2/3] kcmp: Add KCMP_EPOLL_TFD mode to compare epoll target files

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170228065306.GH22938@uranus>
Date:   Tue, 28 Feb 2017 09:53:06 +0300
From:   Cyrill Gorcunov <gorcunov@...il.com>
To:     Andrei Vagin <avagin@...tuozzo.com>
Cc:     linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-api@...r.kernel.org, viro@...iv.linux.org.uk,
        akpm@...uxfoundation.org, xemul@...tuozzo.com,
        mtk.manpages@...il.com, kir@...nvz.org, luto@...capital.net,
        jbaron@...mai.com, Andrey Vagin <avagin@...nvz.org>
Subject: Re: [RFC 2/3] kcmp: Add KCMP_EPOLL_TFD mode to compare epoll target
 files

On Mon, Feb 27, 2017 at 02:43:47PM -0800, Andrei Vagin wrote:
...
> > +
> > +		if (filp1 && filp_epoll) {
> > +			filp_tgt = get_epoll_tfile_raw_ptr(filp_epoll, slot.tfd, slot.toff);
> > +			if (IS_ERR(filp_tgt))
> > +				ret = PTR_ERR(filp_tgt);
> > +			else
> > +				ret = kcmp_ptr(filp1, filp_tgt, KCMP_EPOLL_TFD);
> 
> I think KCMP_FILE has to be used here ^^^^, because we compare files. We
> have to use the same function for all files to be able to sort them, don't we?

Yes. I already have v2 in my queue. Strictly speaking we can use separate
salt here but it will be waste of memory from userspace POV. I didn't send
v2 yet since I'm modifying criu still to test overall picture. Hopefully
will send today.